GTG

sorting of finished tasks is buggy

Bug #538643 reported by Michael Keppler on 2010-03-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	GTG	Fix Released	Medium	Karlo Jež	GTG 0.2.4

Bug Description

When sorting finished tasks by their finished date, the sorting is buggy (as the order is neither ascending nor descending). This is version 0.2.4. I'm using a German locale, if that matters.

See attached screenshot

Related branches

lp://staging/gtg/0.2

lp://staging/~gtg/gtg/old-trunk

Revision history for this message

Michael Keppler (bananeweizen) wrote on 2010-03-14:

screenshot Edit (6.4 KiB, image/png)

Luca Invernizzi (invernizzi) on 2010-03-14

Changed in gtg:
status:	New → Triaged
assignee:	nobody → Luca Invernizzi (invernizzi)
importance:	Undecided → Medium
milestone:	none → 0.2.4
assignee:	Luca Invernizzi (invernizzi) → nobody

Luca Invernizzi (invernizzi) on 2010-03-17

Changed in gtg:
milestone:	0.2.4 → 0.3

Revision history for this message

Bryce Harrington (bryce) wrote on 2010-03-25: Re: [Bug 538643] [NEW] sorting of finished tasks is buggy

On Sun, Mar 14, 2010 at 07:23:55AM -0000, Michael Keppler wrote:
> Public bug reported:
>
> When sorting finished tasks by their finished date, the sorting is buggy
> (as the order is neither ascending nor descending). This is version
> 0.2.4. I'm using a German locale, if that matters.

Confirmed; I've noticed this as well.

Revision history for this message

Karlo Jež (karlo-jez) wrote on 2010-03-27:

sort.patch Edit (531 bytes, text/plain)

Column COL_CDATE is never displayed, but it is used for sorting. Because it is converted to readable string it is sorted by lexicographic order:

2 days ago
300 days ago
50 days ago
today
tomorrow
yesterday

Since COL_CDATE is not displayed, it does not have to be in readable form. This small patch removes to_readable_string() from the task date returned by func. on_get_value() for the column. It seems to fix the sorting problem.
I guess it would be possible to add a special column_id for sorting, but it seems unnecessary for now.

Revision history for this message

Luca Invernizzi (invernizzi) wrote on 2010-03-27:

I love when patches come in. Thanks!