Implement a task detail pane to show in the main taskbrowser window

I'm also a great fan of single clic. I'm still not sure if we should solve that ourselves or at the GTK level.

This is very ugly but this modification of the GTG/taskbrowser/browser.py on_on_task_treeview_button_press_event method allow to open a task with simple click :

    def on_task_treeview_button_press_event(self,treeview,event) :
        if event.button == 3:
            x = int(event.x)
            y = int(event.y)
            time = event.time
            pthinfo = treeview.get_path_at_pos(x, y)
            print pthinfo
            if pthinfo is not None:
                path, col, cellx, celly = pthinfo #pylint: disable-msg=W0612
                treeview.grab_focus()
                treeview.set_cursor( path, col, 0)
                self.taskpopup.popup( None, None, None, event.button, time)
        elif event.button == 1:
            x = int(event.x)
            y = int(event.y)
            time = event.time
            pthinfo = treeview.get_path_at_pos(x, y)
            print pthinfo
            if pthinfo is not None:
                path, col, cellx, celly = pthinfo #pylint: disable-msg=W0612
                treeview.grab_focus()
                treeview.set_cursor( path, col, 0)
                tid = self.get_selected_task(self.task_tview)
                if tid :
                    self.open_task(tid)
            return 1

As I said, it's ugly.

Hmm, we should try it first. I think if we do it we should be 100%
compatible with nautilus behaviour, to provide a consistent feeling
across the applications.

Besides that, the single click view has some issues (even in
nautilus): it is hard to select several resources without activating
them. That could be a problem when coupling this behaviour with the
Mark as done/Dismiss/Delete actions.

On Thu, Mar 12, 2009 at 8:42 PM, Pititjo <email address hidden> wrote:
> This is very ugly but this modification of the
> GTG/taskbrowser/browser.py on_on_task_treeview_button_press_event method
> allow to open a task with simple click :
>
>    def on_task_treeview_button_press_event(self,treeview,event) :
>        if event.button == 3:
>            x = int(event.x)
>            y = int(event.y)
>            time = event.time
>            pthinfo = treeview.get_path_at_pos(x, y)
>            print pthinfo
>            if pthinfo is not None:
>                path, col, cellx, celly = pthinfo #pylint: disable-msg=W0612
>                treeview.grab_focus()
>                treeview.set_cursor( path, col, 0)
>                self.taskpopup.popup( None, None, None, event.button, time)
>        elif event.button == 1:
>            x = int(event.x)
>            y = int(event.y)
>            time = event.time
>            pthinfo = treeview.get_path_at_pos(x, y)
>            print pthinfo
>            if pthinfo is not None:
>                path, col, cellx, celly = pthinfo #pylint: disable-msg=W0612
>                treeview.grab_focus()
>                treeview.set_cursor( path, col, 0)
>                tid = self.get_selected_task(self.task_tview)
>                if tid :
>                    self.open_task(tid)
>            return 1
>
> As I said, it's ugly.
>
> --
> Open task with simple clic
> https://bugs.launchpad.net/bugs/341871
> You received this bug notification because you are a member of Gtg
> developers, which is the registrant for gtg.
>
> Status in Getting Things Gnome!: New
>
> Bug description:
> It will be great to be able to open a task by simple clicking on it in the main view. This could be an option, perhaps using the nautilus comportment.
>

--
Bertrand Rousseau
Place communale 1, 1450 Chastre, Belgium
e-mail : <email address hidden>
tel : +32 485 96 69 86

Nautilus has a user option (Edit → Preferences → Behaviour → Behaviour: Single click to open items) for this.

But I agree there is an issue with selecting versus opening. In Nautilus, I do this by clicking on some whitespace and dragging to select the single item I am concerned with; but in a GTKTreeView that wouldn't work.

Some options to address this: use a "long" click to open directly; or, clicking on the Title column or the text in it (possibly even hyperlinked?) opens the note with a single click.

Bertrand, multi-select doesn't seem possible in GTG right now anyway—unless that is a bug on my end?

I disagree with having this as default. This would mean that if you
mis-click on anything it would open too.. Creating un-needed work to close
it and then click on the correct task.

now that we have mutiple selection support, I don't see an easy way to both keep that and implement a single click behaviour

On Sat, Feb 06, 2010 at 03:58:08AM -0000, Luca Invernizzi wrote:
> now that we have mutiple selection support, I don't see an easy way to
> both keep that and implement a single click behaviour

Agreed with both the previous comments.

I would suggest as an alternative to this... In one of the other bug
reports it's contemplated having the lower panel, which currently shows
closed bugs, show the currently selected task. I would suggest that a
single-click to show a task in this embedded view might make sense.

I do agree though that a single-click resulting in a task editor pop up
would be too disruptive.

  I would suggest that a single-click to show a task in this embedded view
> might make sense.
>
I could go +1 with this option

I confirmed and wishlisted based upon Bryce's suggestion.

This seems to have gone in a weird circle - my original blueprint was for a Task Detail pane of some sort, as Bryce mentioned: https://blueprints.edge.launchpad.net/gtg/+spec/task-detail-pane (with mockup here: http://www.duncanlock.net/misc/screenshots/gtg_task_detail_pane_mockup.png). That Blueprint has recently been marked as superseeded/completed by this bug, oddly. Needless to say, I would love to see that Detail Pane but would hate single click == double click in the current task list.

Hi Duncan. I marked your blueprint as superseded by this bug because I was cleaning up blueprints which had already a bug opened with a similar idea. Having a discussion in blueprints is not easy (there are no comments, only the "whiteboard", when anyone can write-and delete).

On Fri, Feb 12, 2010 at 09:54:44PM -0000, Luca Invernizzi wrote:
> Hi Duncan. I marked your blueprint as superseded by this bug because I
> was cleaning up blueprints which had already a bug opened with a similar
> idea. Having a discussion in blueprints is not easy (there are no
> comments, only the "whiteboard", when anyone can write-and delete).

gtg is a concise enough project that blueprints may be superfluous. I
find them handy myself in Ubuntu, and to a lesser degree in Inkscape,
but for smaller projects I work on I usually just turn blueprints off
and use just the bug tracker. Better to have a unified place for your
work.

Regarding Duncan's point, yeah maybe the title/subject of this bug
should be redone to be something like, "Implement a task detail pane to
show in the main taskbrowser window" or something?

Also, there should probably be a second bug opened for adding the
infrastructure to support the above. I think it should be a
plugin-based mechanism, such as a notebook into which plugins can add
tabs. I'd be willing to take the assignment for implementing this
framework (actually I've already started on it and have made some modest
progress...)

For now I'll leave the blueprints on, as maybe a very smart idea will come through that.
I'd like to see what you're proposing, Bryce! That seems very nice.

On Fri, Feb 12, 2010 at 11:39:55PM -0000, Luca Invernizzi wrote:
> For now I'll leave the blueprints on, as maybe a very smart idea will come through that.
> I'd like to see what you're proposing, Bryce! That seems very nice.

Hi Luca, see linked branches.

Closing this ticket as we do not use LaunchPad anymore, see https://wiki.gnome.org/Apps/GTG to learn more about the current status of the project and to find the new location where our code and bug reports are hosted.

There is a ticket about this issue in the new bug tracker.