grok

grokcore.site: splitted out, so grok should use it

  1. Series 1.1
  2. Bug #314832
Bug #314832 reported by Martijn Faassen
2
Affects Status Importance Assigned to Milestone
grok
Fix Released
Medium
Sylvain Viollon
1.0
Won't Fix
Medium
Sylvain Viollon
1.1
Fix Committed
High
Sylvain Viollon

Bug Description

I split off a grokcore.site package a while ago and placed it here:

http://svn.zope.org/Sandbox/faassen/grokcore.site/

It includes local utility support and such for Grok. We should polish this off and make it a new dependency of Grok (removing the site-specific stuff from Grok proper).

Revision history for this message
Sylvain Viollon (thefunny) wrote :

I can work on that (and by the meantime add support in five.grok as well, I think it's doable).

Changed in grok:
assignee: nobody → thefunny
Revision history for this message
Martijn Faassen (faassen) wrote :

Sylvain, we need to do two things:

* make sure the code in grok and grokcore.site isn't drifting apart and resolve differences

* then *remove* the site code from the grok core and make it depend on grokcore.site

Are you interested in taking care of this?

Revision history for this message
Sylvain Viollon (thefunny) wrote :

* For the first point I already did it. I changed after the code to be able to have a Zope 2 implementation, like explained in the ML.

* For the second point, like explained in the ML, I think we want to do it after 1.0, since we should just fix bugs now. However I asked if it was alright to do so. I never got any reply so I assumed yes.

Revision history for this message
Martijn Faassen (faassen) wrote : Re: [Bug 314832] Re: grokcore.site

On Thu, Jul 9, 2009 at 9:58 AM, Sylvain Viollon<email address hidden> wrote:
>
> * For the second point, like explained in the ML, I think we want to do it after 1.0, since we should just fix bugs now.
> However I asked if it was alright to do so. I never got any reply so I assumed yes.

We're making much bigger changes to try to fix some bugs, so I think
it'd be fine to fold grokcore.site in now. The risks are less big than
many of the other changes we are making.

Revision history for this message
Sylvain Viollon (thefunny) wrote : Re: grokcore.site

Ok, then I will do it as soon as possible.

Reinout van Rees (reinout)
summary: - grokcore.site
+ grokcore.site: splitted out, so grok should use it
Revision history for this message
Sylvain Viollon (thefunny) wrote :

It's done and commited in SVN.

Revision history for this message
Sylvain Viollon (thefunny) wrote :

It's done and in SVN.

Changed in grok:
status: Confirmed → Fix Committed
Michael Haubenwallner (d2m)
Changed in grok:
status: Fix Committed → Fix Released
Revision history for this message
Martijn Faassen (faassen) wrote :

Correction: this wasn't released yet. It's committed for 1.1, though.

Changed in grok:
status: Fix Released → Fix Committed
Revision history for this message
Jan-Jaap Driessen (janjaapdriessen) wrote :

Update: grokcore.site has been released.

Changed in grok:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.