Pre-loading graphs into the composer using a query string breaks if spaces are in any of the targets
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Graphite |
Fix Released
|
Medium
|
Unassigned |
Bug Description
I'm noticing a problem with url escaping/encoding through graphite. It has to do with python's url libs encoding spaces as pluses, and Ext's url decoding not decoding pluses to spaces.
If I create a graph with this target (via the composer):
groupByNode(
and I then copy out the image url, it works
http://
but if I then try to go back to the composer, it fails with a broken image/parse
http://
the reason is that in composer/views.py, the line: 'queryString' : request.
ends up encoding as target=
(spaces translated to pluses)
which is then set in the JS, and parsed in composer.js:loadURL with Ext.urlDecode, but Ext.urlDecode doesn't decode pluses into spaces, so graphite gets confused about how to parse the expression.
Ext.urlDecode(
Object
x: "a+a"
__proto__: Object
simplest fix seems to be changing composer/
thanks,
--dave
Changed in graphite: | |
status: | Fix Committed → Fix Released |
Confirmed this. It actually doesn't seem to like it whether it's a %20 or a + for me