go-onlineaccounts

[TOPBLOCKER] Takes too long (sometimes over 5 seconds) to get the AccessToken from watcher.C

Bug #1387829 reported by Chris Wayne
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
go-onlineaccounts
Fix Committed
Critical
Unassigned

Bug Description

In some go scopes, the scope cannot get the access token to an authenticated account even after 6 seconds of trying. This results in no data being shown, and a "Please setup an account" result being shown, even though there is an account setup, which is of course a horrible user experience.

Prior to watcher.Wait(), I had setup a system to try to get the access token from AuthData, then sleep 100ms and retry if none was receieved. I've seen this run 60 times without receiving the AccessToken from the channel. Is there either a better way to do this from within the scope, or is this an issue with signond itself, or the bindings?

See original description
Tags: rtm14
Chris Wayne (cwayne)
Changed in go-onlineaccounts:
status: New → Confirmed
Chris Wayne (cwayne)
description: updated
Revision history for this message
Chris Wayne (cwayne) wrote :

When I try to use watcher.Settle() it still doesn't work, although if I do the same exact code in account-watcher-test, it gets the AuthData immediately. Is there something different about scopes? Here is my main():

http://paste.ubuntu.com/8750630/

I never see the "signed in" in the logs.

Revision history for this message
Chris Wayne (cwayne) wrote :

Note that If i take out the watcher.Settle() it works, and goes through my sleep-loop 7 times, however for Joe it seems to never get the token even after 60 iterations

Revision history for this message
Joe Odukoya (jodukoya) wrote :

This needs to be raised to Critical and unfortunately needs to be considered as a TOPBLOCKER :-(

tags: added: rtm14
Revision history for this message
Alexander Sack (asac) wrote :

marking critical on request of product team; tagging rtm14 too; discussing whether TOPBLOCKER for rtm

Changed in go-onlineaccounts:
importance: Undecided → Critical
Revision history for this message
Alexander Sack (asac) wrote :

Without knowing details this seem to be two bugs: 1. it takes too long to get token; 2. the scope is buggy in the sense that it cannot deal with slow response time; can we get the scope fixed maybe too?

Revision history for this message
Alexander Sack (asac) wrote :

or maybe the title isn't correct any it really doesnt work at all to get a token?

summary: - Takes too long (sometimes over 5 seconds) to get the AccessToken from
- watcher.C
+ [TOPBLOCKER] Takes too long (sometimes over 5 seconds) to get the
+ AccessToken from watcher.C
Revision history for this message
Olli Ries (ories) wrote :

how does it relate to https://bugs.launchpad.net/ubuntu-system-settings-online-accounts/+bug/1377181

Revision history for this message
Chris Wayne (cwayne) wrote :

@Olli

It doesn't, that bug is about creating accounts, this is about accessing already created accounts from go scopes

@asac

The bug really is more that the online accounts implementation is incomplete. After talking to James, he's finishing it today and then I will be able to use the proper implementation in the scope, hopefully fixing any bugginess there.

Revision history for this message
Chris Wayne (cwayne) wrote :

With James' branches from today I was able to fix my scopes to do this properly, and the access tokens are now received immediately! The scopes will be in the next custom tarball (once it makes it past QA).

Changed in go-onlineaccounts:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.