Music plugin should look for album artwork

Bug #500574 reported by zp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gloobus-preview
Fix Committed
Low
BadChoice

Bug Description

We should look for album artwork in the current folder (cover.jpg, folder.jpg...).

If it's not an overkill we could fetch it from the internet.

Changed in gloobus-preview:
importance: Undecided → Low
status: New → Confirmed
assignee: nobody → BadChoice (guitarboy000)
Revision history for this message
BadChoice (guitarboy000) wrote :

It searchs for the artowk in the folder now

it searches for cover.png or cover.jpg!!

Download it from internet will slow down the application and I think is not a good option

Revision history for this message
zp (zekopeko-deactivatedaccount) wrote :

BadChoice it should also look for folder.jpg/.png/.jpeg

If it doesn't find them then look for any png,jpg,jpeg file in the folder and use that. If there isn't one then use the one we ship with preview.

Revision history for this message
ammonkey (am-monkeyd) wrote :

audio cover added cover/folder png/jpg/jpeg
TODO: If it doesn't find them then look for any png,jpg,jpeg file in the folder and use that

there's no point to go grab on the web a cover because it's the audio player job (exaile etc ...)
where does our main players store their covers?

BadChoice (guitarboy000)
Changed in gloobus-preview:
milestone: none → 0.4.2
status: Confirmed → Fix Committed
Revision history for this message
BadChoice (guitarboy000) wrote :

Depending on the cover, but most players provide a dbus interface to get the cover path, problem is, player needs to be running.

Anyway, we can download the cover from Internet in a separated thread (so preview time is not affected, and when file downloaded show it)

In my covergloobus app I store the covers in ~/.covers so we can use the same

Revision history for this message
vishy (vishwanath-tk) wrote :

What if the album art is added as ID3 tag. I am using the latest version r237 and in that the album art is displayed if the image exist in the folder (for example, cover.jpg in my case). But if the album art is tagged into the mp3/flac, the album art is not displayed any more even if the album art image exists in the folder. Following error is displayed in the terminal.

$ -> gloobus-preview Beera.flac

** (gloobus-preview:13911): WARNING **: Config file couldn't be readed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_width: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_height: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_scale_simple: assertion `GDK_IS_PIXBUF (src)' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_has_alpha: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_add_alpha: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(gloobus-preview:13911): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_width: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_height: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_rowstride: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_new: assertion `width > 0' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_pixels: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_pixels: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(gloobus-preview:13911): GdkPixbuf-CRITICAL **: gdk_pixbuf_get_height: assertion `GDK_IS_PIXBUF (pixbuf)' failed

(gloobus-preview:13911): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.