No more Favicons in Firefox Global Menu Bookmarks subfolders

Correction : favicons are well displayed in global menu of Firefox 7, but not for daily mozilla ppa version (10.0 a1)...

Yeah, I noticed this too. Not sure why this happens yet though, but it seems to be some change in the upstream imagelib code. I did a bit of preliminary debugging last week, and our icon loaders OnStopFrame handler just never gets called despite the fact that imgILoader::LoadImage returns success

Ok, it seems that we're making an invalid assumption about the order of delivery of load and decode notifications, and we're cancelling image loading requests before they're decoded now. That's a relatively easy fix, thankfully

bzr commit -m "Don't cancel the imgIRequest in the OnStopRequest handler, as this might fire before OnStopFrame.
> There is no harm in tying the proxy request lifetime to the menuitems icon loader lifetime, as this actually keeps the real request object in
> the image loader cache (LP: #864511)" --fixes lp:864511
Committing to: /home/chr1s/src/globalmenu-extension/globalmenu-extension/
modified extensions/globalmenu/components/src/uGlobalMenuObject.cpp
Committed revision 263.

Ok, this will be in tomorrows nightly builds, assuming they actually build this time. Please report back if there are still issues with icons, but it seems to do the trick here

The nightly builds are building successfully again now, and this fix is in the latest. Would be great if you could test and see if it resolves it for you

Yes, it's corrected, favicons are well back in global menu of Firefox 10 and in sub-menus, thanks !

Excellent, thanks for testing