--fullscreen causes glmark2 to die when X11 has no _NET_WM_STATE_FULLSCREEN atom
Bug #1270871 reported by
Daniel Kurtz
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
glmark2 |
Fix Committed
|
Undecided
|
Daniel Kurtz |
Bug Description
If the Atom "_NET_WM_
could mean that the active Window Manager is not EWMH compliant, or that
there is no window manager at all. In this case, the XChangeProperty
will fail and the program will terminate with the message:
X Error of failed request: BadAtom (invalid Atom parameter)
Major opcode of failed request: 18 (X_ChangeProperty)
Atom id in failed request: 0x0
Serial number of failed request: 28
Current serial number in output stream: 30
Instead, if the Atom doesn't exist, we might as well just just keep going.
The window will still be fullscreen, it just may still have decorations.
Related branches
Changed in glmark2: | |
status: | New → Fix Committed |
assignee: | nobody → Daniel Kurtz (djkurtz) |
To post a comment you must log in.
Attached is a small patch that keeps glmark2 --fullscreen from dying if the X server doesn't have Atom _NET_WM_ STATE_FULLSCREE N.