wayland - fullscreen does not resize benchmark

Bug #1170510 reported by Joe Konno
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
glmark2
Fix Committed
Undecided
Unassigned

Bug Description

While `glmark2-es2-wayland -b buffer:duration=2 --fullscreen` does indeed create a fullscreen surface, there is insufficient logic to resize the benchmark to the dimensions of that fullscreen surface. The benchmark geometry get set to 640x480. This is obvious when running a Weston instance at high resolution (e.g. 1920x1080).

Tags: wayland
Joe Konno (jbkonno)
description: updated
Darxus (darxus)
tags: added: wayland
Revision history for this message
Joe Konno (jbkonno) wrote :

For displays with multiple possible resolutions-- like my monitor-- glmark2's current logic is generating events for, and handling, every modeline supported by the display and setting it. So, in my case, my display lists modelines from 1920x1080 at various frequencies down to, say, 640x480. N output_mode events are generated, and the benchmark's surface is resized n times, with the final modeline entry being "the" dimensions for the duration of program execution-- in my case, 640x480. After all those events are handled, I have a fullscreen surface (1920x1080) drawing a 640x480 benchmark.

Locally, I set a bit after the first output_mode event is handled, which properly scales the benchmark, and then early-return every event thereafter. In other words, "the first event is right." This gives me the desired result. This is clearly a hack and not a proper fix. Investigating the "right" way to do this.

Revision history for this message
Joe Konno (jbkonno) wrote :

By checking the event's flags, one can determine which events represents the shell's "current" mode. Down the road we may discover a more eloquent way to bring up the window and surface, but this patch appears to enable fullscreen benchmarking on Wayland.

Changed in glmark2:
status: New → In Progress
Revision history for this message
Joe Konno (jbkonno) wrote :

Let me know if there's anything preventing this patch from being merged. Cheers.

Revision history for this message
Jesse Barker (jesse-barker) wrote :

Hi Joe,

I can't test your patch directly at the moment, but if it works for you, I should be able to get it merged over the weekend.

cheers,
Jesse

Revision history for this message
Joe Konno (jbkonno) wrote :

Rafal, could I trouble you for a review? If not, it's cool, but figured I'd ask all the same. ^_^

Revision history for this message
Rafal Mielniczuk (kruk87) wrote :

Hey Joe, I think this patch is good, thanks

regards,
Rafał

Revision history for this message
Jesse Barker (jesse-barker) wrote :

I've applied the patch to trunk.

cheers,
Jesse

Changed in glmark2:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.