CooperativeReader not py3-ready
Bug #1818919 reported by
Brian Rosmaita
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Glance |
Fix Released
|
High
|
Unassigned | ||
| Queens |
New
|
Undecided
|
Unassigned | ||
| Rocky |
New
|
Undecided
|
Unassigned | ||
| Stein |
Fix Released
|
High
|
Unassigned | ||
Bug Description
Tim Burke noticed this in IRC today:
https:/
Should be returning b'' since we're supposed to be returning bytes.
Apparently our unit tests could use some beefing up, because they're not breaking under py3.
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to glance (master) | #1 |
| Changed in glance: | |
| status: | Triaged → Fix Released |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/glance 18.0.0.0rc1 | #2 |
| Changed in glance: | |
| milestone: | none → stein-rc1 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit d5c0daa8b7cbf75
Author: Tim Burke <email address hidden>
Date: Wed Mar 6 14:43:45 2019 -0800
py3: Fix return type on CooperativeRead
This should always be bytes; previously there was a path that returned an empty
native string.
Change-Id: I1cb4997cd3e766
Closes-Bug: #1818919