Glance

Swift acl which disappears on Glance images

  1. Series mitaka
  2. Bug #1584076
Bug #1584076 reported by Nolwenn Cauchois
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Nolwenn Cauchois
Liberty
New
Undecided
Unassigned
Mitaka
Fix Committed
Undecided
Ala Rezmerita

Bug Description

The public images stored in swift have the rights which disappears when we make a "glance image-update".
Consequence : Glance can't fetch the image and the instancation of VM fails with this image.
This bug is only present on the Glance v1 api and it was tested with a juno and mitaka environment.

Here how to reproduce:
http://paste.openstack.org/show/497986/

The problem here is :
- After the modification on the image, acls in reading disappeared ( "Read ACL: ")
- Expected result is "Read ACL: *:*"

See original description
Nolwenn Cauchois (nolwenn)
description: updated
Revision history for this message
Kairat Kushaev (kkushaev) wrote :

Hi, could you please post:
1. Your env version
2. Steps to reproduce
3. Actual result
4. Expected result

Changed in glance:
status: New → Incomplete
Nolwenn Cauchois (nolwenn)
description: updated
Changed in glance:
assignee: nobody → Nolwenn Cauchois (nolwenn-cauchois)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/320588

Changed in glance:
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/320595

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (master)

Change abandoned by Nolwenn Cauchois (<email address hidden>) on branch: master
Review: https://review.openstack.org/320595

Kairat Kushaev (kkushaev)
Changed in glance:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/320588
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=d719b3a1646167e750b9920128d57a7bca331d80
Submitter: Jenkins
Branch: master

commit d719b3a1646167e750b9920128d57a7bca331d80
Author: Nolwenn Cauchois <email address hidden>
Date: Tue May 24 17:01:03 2016 +0200

    Fix bug Swift ACL which disappears on Glance v1 images

    Currently, when we make an update on a public image, Swift ACL disappears.
    This patch allows to avoid the ACL update if there is no change to the
    is_public_attribute.
    If an update is made on a Glance image without changing the public attribute
    or location, then the function which modifies ACLS is not called, in order
    to keep ACLS.

    Closes-Bug: 1584076

    Change-Id: I21e9deb9105faee87500998eff47c6faa1d02914

Changed in glance:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/glance 13.0.0.0b2

This issue was fixed in the openstack/glance 13.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/368609

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/mitaka)

Reviewed: https://review.openstack.org/368609
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=389071274f29d14f9a48a8b56f929a4682e6d383
Submitter: Jenkins
Branch: stable/mitaka

commit 389071274f29d14f9a48a8b56f929a4682e6d383
Author: Nolwenn Cauchois <email address hidden>
Date: Tue May 24 17:01:03 2016 +0200

    Fix bug Swift ACL which disappears on Glance v1 images

    Currently, when we make an update on a public image, Swift ACL disappears.
    This patch allows to avoid the ACL update if there is no change to the
    is_public_attribute.
    If an update is made on a Glance image without changing the public attribute
    or location, then the function which modifies ACLS is not called, in order
    to keep ACLS.

    Closes-Bug: 1584076

    Change-Id: I21e9deb9105faee87500998eff47c6faa1d02914
    (cherry picked from commit d719b3a1646167e750b9920128d57a7bca331d80)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.