Unexpected verifier=None kwarg is making stable/liberty unit tests intermittently fail

Bug #1548902 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Invalid
Undecided
Unassigned
Liberty
Fix Committed
High
Matt Riedemann
glance_store
Invalid
Undecided
Unassigned
Liberty
Fix Committed
Medium
Matt Riedemann
Revision history for this message
Matt Riedemann (mriedem) wrote :

The tests were removed in master:

https://review.openstack.org/#/c/273789/

So stable/liberty is probably failing b/c it's picking up newer glance-store which has changes that stable/liberty can't handle.

Revision history for this message
Matt Riedemann (mriedem) wrote :

Here is the glance backport for liberty: https://review.openstack.org/#/c/283708/

Here is the glance-store backport for liberty: https://review.openstack.org/#/c/283689/

Changed in glance:
status: New → Invalid
Changed in glance-store:
status: New → Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to glance_store (stable/liberty)

Reviewed: https://review.openstack.org/283689
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=7b13ce62b46c327b90e6b8c0eb85a1f2c8dec217
Submitter: Jenkins
Branch: stable/liberty

commit 7b13ce62b46c327b90e6b8c0eb85a1f2c8dec217
Author: Sabari Kumar Murugesan <email address hidden>
Date: Thu Jan 28 14:07:51 2016 -0800

    Add backend tests from glance

    Moves some unit tests that were part of glance but should have
    belonged to glance_store.

    These tests are ported from
    glance/tests/unit/test_store_image.py

    Related-Bug: #1548902

    NOTE(mriedem): As part of the backport we have to remove
    the verifier=None kwargs from the assertions made in
    test_backend since the verifier code didn't exist in
    stable/liberty.

    Change-Id: I688629d37e9146aef33fbc9bb6fd8780521e06ab
    (cherry picked from commit 5faadde2d63d0bb7de12958c6e79040d6cc0448c)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/liberty)

Reviewed: https://review.openstack.org/283708
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=4f41717204dea123fac1050956cd87dea261794e
Submitter: Jenkins
Branch: stable/liberty

commit 4f41717204dea123fac1050956cd87dea261794e
Author: Brianna Poulos <email address hidden>
Date: Fri Jan 22 15:13:35 2016 -0500

    Remove unneeded glance unit test assert calls

    The glance_store library now accepts a verifier object for use with
    verifying signatures, as a result of a recently merged patch [1].
    There are some glance unit tests that do not expect this verifier
    object to be passed to the add method of glance_store, and will
    therefore fail with a new release of the glance_store library.

    This patch removes the assert lines for the tests that will fail,
    since it is not necessary for glance to test glance_store in that
    way at the glance level.

    [1] https://review.openstack.org/#/c/183110/

    Change-Id: I404fbc40dafa159a63a6dfee563f05ee80c073dc
    Partial-Bug: #1516031
    (cherry picked from commit eab1567d48a18fa968c7b66c3641dd037da1f84e)

    -- squashed with another change to get liberty working --

    Remove glance_store specific unit tests

    TestStoreAddToBackend contains a set of tests that should belong to
    the glance_store. Recently, these tests were about to break
    glance as they mocked internal methods. Those mocks were
    removed in commit eab1567d48a18fa968c7b66c3641dd037da1f84e.

    The tests are added back to glance_store in
    change https://review.openstack.org/#/c/273786.

    Conflicts:
            glance/tests/unit/test_store_image.py

    Closes-Bug: #1548902

    Depends-On: I688629d37e9146aef33fbc9bb6fd8780521e06ab
    Change-Id: Ic67826a4d02cb30cc429a3d4abc46d6ca96f31ad
    (cherry picked from commit 1ebbfd3dc1694dc4f26e763da9eee833bb5d2545)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 11.0.2

This issue was fixed in the openstack/glance 11.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.