Glance compute-vcputopology defs names are missing underscore

Bug #1712809 reported by Maciej Kucia
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
In Progress
Undecided
Maciej Kucia

Bug Description

In file glance/etc/metadefs/compute-vcputopology.json

One can find following properties
 "cpu_sockets"
 "cpu_cores"
 "cpu_threads"
 "cpu_maxsockets"
 "cpu_maxcores"
 "cpu_maxthreads"

But the correct names are as in https://review.openstack.org/#/c/196080/2/nova/virt/hardware.py
 "cpu_sockets"
 "cpu_cores"
 "cpu_threads"
 "cpu_max_sockets"
 "cpu_max_cores"
 "cpu_max_threads"

Underscores are missing

https://github.com/openstack/glance/blob/master/etc/metadefs/compute-vcputopology.json#L38
https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L265

Tags: metadef
Revision history for this message
Maciej Kucia (maciejkucia) wrote :

This bug was found on Ocata but I cannot figure out how to select Ocata here on launchpad.

Aizuddin Zali (mymzbe)
tags: added: metadef
Aizuddin Zali (mymzbe)
Changed in glance:
assignee: nobody → Aizuddin Zali (mymzbe)
status: New → Confirmed
Revision history for this message
Maciej Kucia (maciejkucia) wrote :

I have already posted fix but for some reason it is not reflected here
https://review.openstack.org/#/c/497225/

Revision history for this message
Aizuddin Zali (mymzbe) wrote :

That is weird, I saw that your commit message is correct for this bug.

Changed in glance:
assignee: Aizuddin Zali (mymzbe) → Maciej Kucia (maciejkucia)
status: Confirmed → In Progress
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
Maciej Kucia (maciejkucia) wrote :

Related changes:

 nova Abandoned: Correct image metadata key names to glance definition
 https://review.openstack.org/#/c/367627/

 Glance! Abandoned: Fix inconsistent metadata names
 https://review.openstack.org/#/c/303658/

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.