technical debt: replace a location_stragegy test
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Glance |
Triaged
|
Medium
|
Unassigned | ||
Bug Description
Here's the situation.
There was a discussion during the Newton-Ocata time frame about whether glance supports custom location_strategy modules. We decided that it does not, and at that time used the 'choices' parameter in the location_strategy api config option (defined using oslo.config) to restrict the names the option could take to the two location strategy modules that come with glance. There's code that checks to make sure the module set by the config module actually exists. We had a test for this that used an override in oslo.config to set the location_strategy option to something like 'invalid_module' and then tested to make sure the missing module was handled properly. In the meantime, oslo.config has removed the ability to do this kind of override. So the test has to be changed.
We don't have bandwidth to get into this right now, so I'm filing this bug to remind us to go back and fix this when someone has time. Here's the patch that removes the test:
https:/
| Sean McGinnis (sean-mcginnis) wrote | #1 |
| Brian Rosmaita (brian-rosmaita) wrote | #2 |
I think this can actually be closed. Since the config option enforces input now, and the only defined acceptable input are the two options that we know are good, it actually looks like this code isn't needed anymore and can just be removed.