Glance

chunk sender does not send terminator on subprocess exception

Bug #1365637 reported by Jesse J. Cook
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Glance
New
Undecided
Unassigned
OpenStack Compute (nova)
Fix Released
Undecided
Jesse J. Cook
OpenStack Compute (nova) 2014.2 "juno"

Bug Description

If a subprocess exception occurs when uploading chunks via glance, eventlet.wsgi.py will result in the following exception: ValueError: invalid literal for int() with base 16: ''. This happens because the chunk sender does not send the terminator and the server reads an EOF on client connection close instead of a properly formatted chunk.

Jesse J. Cook (jesse-j-cook)
Changed in nova:
assignee: nobody → Jesse J. Cook (jesse-j-cook)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/119167

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/119167
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e039b036b5e9dbaff8b37f7ab22c209b71bdc182
Submitter: Jenkins
Branch: master

commit e039b036b5e9dbaff8b37f7ab22c209b71bdc182
Author: Jesse J. Cook <email address hidden>
Date: Thu Sep 4 13:17:37 2014 -0500

    xenapi: send chunk terminator on subprocess exc

    During chunk upload if a subprocess exception is thrown, a malformed
    chunk upload occurs.

    This patch adds logging for subprocess exceptions and sends the
    terminator even in the event of a subprocess exception. The incomplete
    file upload will then be cleaned up by the client.

    Change-Id: I559f201430bcd4c36d669c7772a10bfe3cd54d41
    Closes-Bug: 1365637

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.