Glance

debug level logs should not be translated

Bug #1317847 reported by Christian Berendt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Undecided
Unassigned
Glance 2014.2 "juno"

Bug Description

According to the OpenStack translation policy, available at https://wiki.openstack.org/wiki/LoggingStandards, debug messages should not be translated. Like mentioned in several changes in Nova by garyk this is to help prioritize log translation.

Zhi Yan Liu (lzy-dev)
Changed in glance:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/93018
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=86dd9ff66c0f2b7ded9d94aa8fb2663c28196e23
Submitter: Jenkins
Branch: master

commit 86dd9ff66c0f2b7ded9d94aa8fb2663c28196e23
Author: Christian Berendt <email address hidden>
Date: Fri May 9 12:33:21 2014 +0200

    debug level logs should not be translated

    According to the OpenStack translation policy available at
    https://wiki.openstack.org/wiki/LoggingStandards debug messages
    should not be translated. Like mentioned in several changes in
    Nova by garyk this is to help prioritize log translation.

    This patch adds a new hacking check - N319 - that ensures all
    debug log messages don't have translations.

    Change-Id: I9dd958b904671a7eb95883026e14684469dc52d5
    Closes-Bug: #1317847

Changed in glance:
status: Triaged → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to glance (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/95823

Thierry Carrez (ttx)
Changed in glance:
milestone: none → juno-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to glance (master)

Reviewed: https://review.openstack.org/95823
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=db2a5674c0818856cee618b2dbb540d820dce15d
Submitter: Jenkins
Branch: master

commit db2a5674c0818856cee618b2dbb540d820dce15d
Author: Erno Kuvaja <email address hidden>
Date: Mon Jun 9 10:46:03 2014 +0000

    Removing translation from debug messages

    Related bug #1317847

    Change-Id: I1dfaee94300178da3200edc219ce3d00b0689bdc

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/109230

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (stable/icehouse)

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/109230
Reason: I've found a better way to cherry-pick without that change, so abandoning it.

Thierry Carrez (ttx)
Changed in glance:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.