git-ubuntu

Applied branches remove .pc even when not format 3.0 (quilt)

Bug #1734346 reported by Robie Basak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
git-ubuntu
New
Undecided
Unassigned

Bug Description

Based on my reading of importer.py:import_patches_applied_tree, we commit a .pc removal (if it existed) before we check for 3.0 (quilt). I'm not sure this is correct. If not 3.0 (quilt), then I think any '.pc' directory is legitimately part of the source package by Debian policy and could be required by something in debian/rules for example.

Robie Basak (racb)
tags: added: import
Revision history for this message
Nish Aravamudan (nacc) wrote :

I believe this is the same thing dgit does, but I need to refresh my memory to be sure.

In any case, it's not necessarily possible for patches-applied import to work (or to know what state we are in) without removing the .pc directory first.

Revision history for this message
Robie Basak (racb) wrote :

> it's not necessarily possible for patches-applied import to work

patches-applied shouldn't happen for non 3.0 (quilt) though, right?

Revision history for this message
Robie Basak (racb) wrote :

(I realise that this is perhaps contrary to the subject line of this bug)

Robie Basak (racb)
tags: added: applied spec
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.