GenOS

eBuild fails to patch GRUB menu entry

Bug #792441 reported by Sergey "Shnatsel" Davidoff
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
GenOS
Fix Committed
Low
Unassigned
elementary OS
Won't Fix
Low
Unassigned
0.2-luna
Won't Fix
Low
Unassigned
ugr-ebuild
Won't Fix
Undecided
Unassigned

Bug Description

eBuild was replacing stock ubuntu GRUB entry without checking if it has changed or not. I've converted it to a contextual patch with error handling, and now it fails to apply on Natty because the upstream file has changed. So, we need to make a similar patch that works for Natty.

Sergey "Shnatsel" Davidoff (shnatsel)
tags: added: grub
Sergey "Shnatsel" Davidoff (shnatsel)
Changed in elementaryos:
assignee: nobody → Avi Romanoff (aroman)
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Assigning ~aroman, he seems to be the guy who made it for Jupiter.

Revision history for this message
Eduard Gotwig (gotwig) wrote :

isnt this fixed now?

Revision history for this message
Eduard Gotwig (gotwig) wrote :

ok, no its not, there is still a bug with grub, says eBuild.

Revision history for this message
Avi Romanoff (aroman) wrote : Re: [Bug 792441] Re: eBuild fails to patch GRUB menu entry

Shnatsel is correct in that I was the one who created the current GRUB patch. However, I realize that it is more of a hack than a legitimate fix. I'm admittedly not a GRUB expert -- the hack I implemented for Jupiter basically works by using the nickname of the OS from the `uname` command. I believe that if you change the nickname appropriately it should function normally in Luna. That said, I would definitely consider researching an alternative system to accomplish what were trying to do and have it work reliably in the long term and with future releases. I was pressed for time with Jupiter and did not have the time.

On Jun 3, 2011, at 6:23 PM, Eduard Gotwig <email address hidden> wrote:

> ok, no its not, there is still a bug with grub, says eBuild.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/792441
>
> Title:
> eBuild fails to patch GRUB menu entry
>
> Status in elementary OS:
> Confirmed
>
> Bug description:
> eBuild was replacing stock ubuntu GRUB entry without checking if it
> has changed or not. I've converted it to a contextual patch with error
> handling, and now it fails to apply on Natty because the upstream file
> has changed. So, we need to make a similar patch that works for Natty.

Avi Romanoff (aroman)
Changed in elementaryos:
assignee: Avi Romanoff (aroman) → nobody
Revision history for this message
abrsdk (abrsdk) wrote :

hope it gets fixed soon.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

It's not really a vast bug, it's just a minor branding issue... there are higher-priority tasks at the moment.

Sergey "Shnatsel" Davidoff (shnatsel)
tags: added: branding
Revision history for this message
Eduard Gotwig (gotwig) wrote :

I installed the last version of Luna (from a built iso image with eBuild). It showed Ubuntu with Linux kernel 3.0 or sth like that in the Grub boot menu

Ivo Nunes (ivonunes)
Changed in gen-os:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Ivo Nunes (netherblood)
Revision history for this message
Ivo Nunes (ivonunes) wrote :

This bug has been fixed on latest GenOS trunk. If you want to use the fix, get my updated 10_linux.patch and check the changes I made to conf.sh.

Changed in gen-os:
status: Confirmed → Fix Committed
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Ivo Nunes: you still will have it overwritten by upstream entries on software updates. Using eBuild is a bad idea, this legacy script is not the right way to build OS images. We're dropping eBuild in elementary OS ASAP. If you want a good build, consider using Ubuntu Customization Kit.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

We've ditched eBuild. FINALLY!!!

Sergey "Shnatsel" Davidoff (shnatsel)
Changed in elementaryos:
status: Confirmed → Won't Fix
Revision history for this message
JC Hulce (soaringsky) wrote :

we no longer use ebuild

Changed in ugr-ebuild:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.