libgeda FTBFS on Hurd

Bug #1187348 reported by أحمد المحمودي (Ahmed El-Mahmoudy)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Confirmed
Medium
Unassigned

Bug Description

libgeda FTBFS on Hurd with the following error:

 f_basic.c:662:31: error: 'MAXPATHLEN' undeclared (first use in this function)
 f_basic.c:662:31: note: each undeclared identifier is reported only once for each function it appears in

I was talking now with Debian's GNU/Hurd porters, and they had the following comments on the code:
* fix it to not rely on static buffers for file paths
* while PATH_MAX is POSIX, although optional (and Hurd does not provide it on purpose), MAXPAtHLEN is nowhere standard
* hardcoding MAX_LINK_LEVEL is wrong too, since there is a proper way (using sysconf) to get the maximum level of symlinks before returning ELOOP
* follow_symlinks function looks like a realpath() reimplementation, and if that function could not be just a realpath replacement, it seems g_file_read_link would eventually fail also on ENAMETOOLONG, so the own MAXPATHLEN check could go

Tags: libgeda
Peter TB Brett (peter-b)
tags: added: libgeda
Peter TB Brett (peter-b)
Changed in geda:
importance: Undecided → Medium
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.