gEDA project

Documentation for "Arc" is wrong

Bug #1492497 reported by dima on 2015-09-04

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	gEDA project	Fix Committed	Low	Unassigned
	pcb	Fix Released	Low	Bert Timmerman	pcb pcb-4.0.0

Bug Description

The documentation for the 'width' and 'height' parameters of Arc is 'The width and height, from the center to the edge'. I'm observing this to be incorrect: it's from the center to the center of the arc, not the edge. Also, either of these isn't a "width", rather it's more of a "radius_x" and "radius_y". Thanks

Tags:

Revision history for this message

Vladimir Zhbanov (vzhbanov) wrote on 2015-09-05:

Hi, Dima.

What documentation do you mean?

Cheers,
Vladimir

tags:

added: docs

Vladimir Zhbanov (vzhbanov) on 2015-09-13

Changed in geda:
status:	New → Incomplete
importance:	Undecided → Low

Revision history for this message

dima (9-ubuntu-4) wrote on 2015-09-13:

I sent this to the launchpad bug email address on Sep 5. Apparently it only pretends to work

Vladimir Zhbanov <email address hidden> writes:

> What documentation do you mean?

parse_y.y line 985 and the documents linked here:

http://pcb.geda-project.org/manual.html

Those documents probably are generated from that file.

Revision history for this message

Vladimir Zhbanov (vzhbanov) wrote on 2015-09-14:

Hi, Dima.

Pcb has another launchpad tracker.

Thank you for the report,
Vladimir

affects:	geda → pcb
Changed in pcb:
status:	Incomplete → New

Revision history for this message

Bert Timmerman (bert-timmerman) wrote on 2015-09-14:

A patch is pushed into upstream topic branch LP1492497.

Please review.

Kind regards,

Bert Timmerman.

Changed in pcb:
status:	New → In Progress
assignee:	nobody → Bert Timmerman (bert-timmerman)
milestone:	none → next-bug-release

Revision history for this message

Bert Timmerman (bert-timmerman) wrote on 2015-09-14:

http://git.geda-project.org/pcb/commit/?h=LP1492497&id=77b91d6d06c9a4c5284f1baa70deb8a406216184

Revision history for this message

dima (9-ubuntu-4) wrote on 2015-09-14:

Hi. Thanks for the patch. It's incomplete, however. The values affect the distance to the middle of the arc, not its edge.

Revision history for this message

Bert Timmerman (bert-timmerman) wrote on 2015-09-14:

LP1492497.pcb Edit (1003 bytes, text/plain)

Hi dima,

I do not understand what you exactly mean by: "I'm observing this to be incorrect: it's from the center to the center of the arc, not the edge.".

I attached a test file containing two arcs:

Arc[100.00mil 200.00mil 100.00mil 100.00mil 10.00mil 20.00mil -90 -90 "clearline"]
Arc[300.00mil 150.00mil 50.00mil 50.00mil 10.00mil 20.00mil -90 -90 "clearline"]

The first arc has a center point at [100 mil, 200 mil] with a RadiusX and RadiusY of 100 mil, and was created by clicking on [100,100] and [200,200].

The second arc has a center point of [300 mil, 150 mil] with a RadiusX and RadiusY of 50 mil, and was created by clicking on [300,100] and [350,150].

Kind regards,

Bert Timmerman.

Revision history for this message

dima (9-ubuntu-4) wrote on 2015-09-14:

Hi. Your first arc has a thickness of 10mil, and the distance from the center point (100,200) to the centerline is 100mil. The distance from the center point to the outer edge is 100+10/5 = 105mil. The documentation calls this distance "from the center to the edge". That wording makes me think it refers to the 105mil distance, not the 100mil distance.

Traumflug (mah-jump-ing) on 2015-09-27