Linaro GCC

EE pass mishandles subregs of promoted variables

Bug #728315 reported by Richard Sandiford
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro GCC
Fix Released
Undecided
Richard Sandiford
Linaro GCC 4.5-2011.04-0
Linaro GCC Tracking
Invalid
Undecided
Richard Sandiford
Linaro GCC Tracking 4.7.0

Bug Description

The bug reported here:

    https://lists.openwrt.org/pipermail/openwrt-devel/2011-March/009847.html

is caused by a mishandling of subregs of promoted variables in the Linaro/CS-specific extension-elimination pass. These subregs record that the inner register is known to be sign- or zero-extended beyond the outer mode, so the pass should should either remove the promoted flag or treat these subregs as referring to the whole of the inner register. the former would pessimise combine (which makes good use of these notes) and the latter seems more in keeping with this style of pass.

Related branches

lp://staging/~rsandifo/gcc-linaro/lp-728315
Andrew Stubbs (community): Approve
Diff: 29 lines (+10/-1)
2 files modified
ChangeLog.linaro (+5/-0)
gcc/ee.c (+5/-1)
lp://staging/gcc-linaro/4.5
Revision history for this message
Andrew Stubbs (ams-codesourcery) wrote :

I've just merged Richard's patch into lp:gcc-linaro/4.5

Changed in gcc-linaro:
milestone: none → 4.5-2011.04-0
status: In Progress → Fix Committed
Revision history for this message
Andrew Stubbs (ams-codesourcery) wrote :

Assigning Richard to submit this upstream (or mark it "Invalid", if that's not appropriate).

Related: lp:gcc-linaro/4.5,revno=99488

Changed in gcc-linaro-tracking:
assignee: nobody → Richard Sandiford (rsandifo)
milestone: none → 4.7.0
Richard Sandiford (rsandifo)
Changed in gcc-linaro-tracking:
status: New → Invalid
Michael Hope (michaelh1)
Changed in gcc-linaro:
status: Fix Committed → Fix Released
Andrew Stubbs (ams-codesourcery)
tags: added: 46merge
Andrew Stubbs (ams-codesourcery)
tags: removed: 46merge
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.