Firmware Test Suite

Test of setwakeuptime may be incorrect

Bug #1994498 reported by chendong on 2022-10-26

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Firmware Test Suite	Incomplete	Undecided	Ivan Hu

Bug Description

ArmSystemReady certification is in progress on our side, and we encountered problems with setwakeuptime testing during FWTS testing.(FWTS code from https://git.launchpad.net/fwts)

When testing the functionality of setwakeuptime, the code calls getwakeuptime to get the values of wakeuptime, pending, and enable, but the values of pending are not false. We write the pending value directly false in the firmware's getwakeuptime interface, but the test still fails.

Print information for test failure:
Test 22 of 36: Test UEFI RT Service set wakeup time interface.
FAILED [HIGH] UEFIRuntimeSetWakeupTimePending: Test 22, Get error alarm signal status.

Test Code:
https://git.launchpad.net/fwts/tree/src/uefi/uefirttime/uefirttime.c?h=V22.01.00#n921

In addition, we use the FWTS tool from https://fwts.ubuntu.com/fwts-live/ was tested and found that the setwakeuptime test passed when using the graphical interface, but testing at the command line was problematic.

Revision history for this message

Ivan Hu (ivan.hu) wrote on 2022-11-01:

Could you prove the result.log from FWTS?

Changed in fwts:
assignee:	nobody → Ivan Hu (ivan.hu)

Revision history for this message

chendong (dchen233) wrote on 2022-11-04:

FWTSResults.log Edit (100.3 KiB, text/plain)

The attachment is FWTS result.

Revision history for this message

Ivan Hu (ivan.hu) wrote on 2022-11-11:

I am not able to find a device which can reproduce this issue.
The alarm signal status is passed from firmware, here should be the uboot.

As you mentioned above, you used fwts-live image to test your device.
The graphic pass but command line not, which fwts-live you used for testing?
And could you provide the fwts-live test log, graphic and commnand line one?

I am guessing if it is the issue that when setwakeuptime and your device haven't set the Pending to false before FWTS has already got the Pending status.

I don't know if your device can boot to Ubuntu, if yes, I could sent you some test patches for dumping some messages and testing, you can build the fwts and run directly.

Changed in fwts:
status:	New → In Progress

Ivan Hu (ivan.hu) on 2022-11-15

Changed in fwts:
status:	In Progress → Confirmed

Revision history for this message

chendong (dchen233) wrote on 2022-11-15:

uefirttime_Problem_description.zip Edit (399.9 KiB, application/zip)

First,for cases where you cannot find a device that replicates the problem, the attachment further describes the problem on our side. We have collected log files from the FWTS-live test project through a graphical interface and command line. (It should be emphasized that we use the same BIOS, but the test results are different for both)

Regarding your suspicion that the firmware does not set pending to false in setwakeuptime. We checked the setwakeuptime interface here, and we modified the getwakeuptime interface so that the pending value is always false, but the test item still shows failure.

Finally, the device here can boot ubuntu-server-22.04-arm64. If possible, we are also happy to cooperate with some tests.

Looking forward to your response.

Revision history for this message

Ivan Hu (ivan.hu) wrote on 2022-11-23:

Thanks for your analysis log,

Could you try to get the source of FWTS, build and test to see if the issue can be reproduced under ubuntu 22.04?

Source code:
$git clone git://kernel.ubuntu.com/hwe/fwts.git
Configure:
$sudo apt-get build-dep fwts
$autoreconf -ivf
$./configure
Compile: $make
Install: $sudo make install

Revision history for this message

Ivan Hu (ivan.hu) wrote on 2023-03-14:

0001-uefirttime-test-the-delay-for-arm-wakeup-pending-sta.patch Edit (1.2 KiB, text/plain)

I am not able to find a device which can reproduce this issue.
If you are able to build the the FWTS on your device, could you help to test with the test patch(attachment)?