Fuel for OpenStack

User cannot deploy changes, because button has disappeared on UI

  1. Series ocata
  2. Bug #1650663
Bug #1650663 reported by Nastya Urlapova
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Julia Aranovich
Fuel for OpenStack 11.0
Mitaka
Fix Released
High
Julia Aranovich
Fuel for OpenStack 9.2
Newton
Fix Released
High
Julia Aranovich
Fuel for OpenStack 10.1
Ocata
Fix Committed
High
Julia Aranovich
Fuel for OpenStack 11.0

Bug Description

This issues was found while exploratory testing. After unsuccessful deploy https://bugs.launchpad.net/fuel/+bug/1650652, I've added systemd-shim package into list of extra packages, see pic 1., further I've saved the settings. But on the main tab, "Deployment changes" button didn't appeared, see pic 2.

Conclusion what UI-team has provided:
user doesn't see "Deploy changes" button, because initial hash for deployment wasn't saved GET /api/clusters/1/attributes/deployed. And new setting have nothing to compare.

A brief scenario:
1. get an error on deployment
2. change smth. in general settings
3. try to deploy changes

Version:
9.x snapshot #638

Revision history for this message
Nastya Urlapova (aurlapova) wrote :
Changed in fuel:
milestone: none → 9.2
Revision history for this message
Nastya Urlapova (aurlapova) wrote :
Revision history for this message
Nastya Urlapova (aurlapova) wrote :
tags: added: fuel-ui
Oleksiy Molchanov (omolchanov)
Changed in fuel:
status: New → Confirmed
tags: added: fuel-python
Revision history for this message
Vladimir Kuklin (vkuklin) wrote :

I failed to reproduce the issue with an existing environment. Will try to do it with brand new one.

Julia Aranovich (jkirnosova)
tags: added: area-python area-ui
removed: fuel-python fuel-ui
Revision history for this message
Stanislaw Bogatkin (sbogatkin) wrote :

I have seen this exact bug when tested other stuff yesterday. Problem also disappeared after cluster reset and successful deploy.

Revision history for this message
Vladimir Kuklin (vkuklin) wrote :

I failed to reproduce this scenario with brand new environment either:

1. Have sample 3controller+1compute env
2. Put some gibberish to fuel_pkgs.pp manifest
3. Run the deployment
4. Deployment fails
5. Change repositories settings and something else.
6. Deploy Changes button is still in place.

Changed in fuel:
status: Confirmed → Incomplete
Revision history for this message
Vladimir Kuklin (vkuklin) wrote :

Okay, I finally got it. If /api/clusters/{cluster_id}/attributes/deployed returns an empty hash (which is ok, because there has not been a single successful deployment yet), then Deployed Changes button is not shown. I am pretty sure that if have empty deployed hash, then this would mean that we have not deployed anything yet and 'Deploy Changes' button should be shown. Thus I will reassign this bug to fuel-ui team

Changed in fuel:
status: Incomplete → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/413466

Changed in fuel:
assignee: Fuel UI Team (fuel-ui) → Julia Aranovich (jkirnosova)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/413466
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=a4eebede2d3840c2665468b8c0d791bf63443233
Submitter: Jenkins
Branch: master

commit a4eebede2d3840c2665468b8c0d791bf63443233
Author: Julia Aranovich <email address hidden>
Date: Wed Dec 21 10:41:37 2016 +0300

    Allow to redeploy error nodes

    If there are error nodes in cluster,
    Deploy Changes button should be available on Dashboard
    for user to be able to redeploy the nodes.

    Closes-Bug: #1650663

    Change-Id: Ife0c0034fd181caf84ec22ac738118f0fbaae81d

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/413518

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/413520

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (stable/newton)

Reviewed: https://review.openstack.org/413518
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=2dc13ee6641d831f45d2d35d0978378f27321442
Submitter: Jenkins
Branch: stable/newton

commit 2dc13ee6641d831f45d2d35d0978378f27321442
Author: Julia Aranovich <email address hidden>
Date: Wed Dec 21 10:41:37 2016 +0300

    Allow to redeploy error nodes

    If there are error nodes in cluster,
    Deploy Changes button should be available on Dashboard
    for user to be able to redeploy the nodes.

    Closes-Bug: #1650663

    Change-Id: Ife0c0034fd181caf84ec22ac738118f0fbaae81d
    (cherry picked from commit a4eebede2d3840c2665468b8c0d791bf63443233)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (stable/mitaka)

Reviewed: https://review.openstack.org/413520
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=1dde97671f65d70dd3c9f3e7cb3f566ea21271df
Submitter: Jenkins
Branch: stable/mitaka

commit 1dde97671f65d70dd3c9f3e7cb3f566ea21271df
Author: Julia Aranovich <email address hidden>
Date: Wed Dec 21 10:41:37 2016 +0300

    Allow to redeploy error nodes

    If there are error nodes in cluster,
    Deploy Changes button should be available on Dashboard
    for user to be able to redeploy the nodes.

    Closes-Bug: #1650663

    Change-Id: Ife0c0034fd181caf84ec22ac738118f0fbaae81d
    (cherry picked from commit a4eebede2d3840c2665468b8c0d791bf63443233)

Ekaterina Shutova (eshutova)
tags: added: on-verification
Revision history for this message
Ekaterina Shutova (eshutova) wrote :

Verified on 9.2 snapshot #666

tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-ui 11.0.0.0rc1

This issue was fixed in the openstack/fuel-ui 11.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.