[octane] network template omitted if replaced_deployment_info exists

Bug #1572240 reported by Roman Sokolkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Roman Sokolkov
7.0.x
Fix Committed
High
Unassigned
8.0.x
Fix Committed
High
Unassigned
Newton
Fix Committed
High
Roman Sokolkov

Bug Description

I'm trying to upgrade MOS6.0 to MOS8.0 (Octane version stable/8.0).

Trying to use network template for new environment, but found following limitation.

Context is following:
Nailgun will NOT apply any new settings if replaced_deployment_info exists for node. (Per Alexey Kasatkin)

In case Octane, it replaces deployment info in handler "predeploy" for controllers.

So we can not make any changes for node after that.

This basically means that we should apply network templates before "predeploy" handler.

https://github.com/openstack/fuel-octane/blob/stable/8.0/octane/commands/upgrade_node.py#L56

Dmitry Klenov (dklenov)
tags: added: area-python
no longer affects: fuel/mitaka
tags: added: non-release
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (master)

Fix proposed to branch: master
Review: https://review.openstack.org/321376

Changed in fuel:
assignee: Fuel Octane (fuel-octane-team) → Roman Sokolkov (rsokolkov)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/321376
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=62f75c10445a3cd275c86dae8028e8f444ef1968
Submitter: Jenkins
Branch: master

commit 62f75c10445a3cd275c86dae8028e8f444ef1968
Author: Roman Sokolkov <email address hidden>
Date: Thu May 26 09:36:27 2016 +0300

    Apply network templates before preupgrade handler

      Controller's "preupgrade" handler replaces
      deployment_info if "isolated". After that
      Octane applies network template.

      But nailgun will NOT apply any new settings
      if replaced_deployment_info exists for node.

      Closes-bug: 1572240

    Change-Id: I06922a59a5f6976acb7c268460fb95fcde86aa54

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-octane (stable/8.0)

Change abandoned by rsokolkov (<email address hidden>) on branch: stable/8.0
Review: https://review.openstack.org/321372
Reason: Please create new cherry-pick from master branch

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/322070

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/322070
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=75dc1ed12f43ac7c7c1e3fe3397993218bacc85c
Submitter: Jenkins
Branch: stable/8.0

commit 75dc1ed12f43ac7c7c1e3fe3397993218bacc85c
Author: Roman Sokolkov <email address hidden>
Date: Thu May 26 09:36:27 2016 +0300

    Apply network templates before preupgrade handler

      Controller's "preupgrade" handler replaces
      deployment_info if "isolated". After that
      Octane applies network template.

      But nailgun will NOT apply any new settings
      if replaced_deployment_info exists for node.

      Closes-bug: 1572240

    (cherry picked from commit 62f75c10445a3cd275c86dae8028e8f444ef1968)

    Change-Id: I244e9da3c6f9f28da49964dcda1bd619f9912ced

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/7.0)

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/322348

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/7.0)

Reviewed: https://review.openstack.org/322348
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=ebab9a6562c56336a845599332e378d32863ed5f
Submitter: Jenkins
Branch: stable/7.0

commit ebab9a6562c56336a845599332e378d32863ed5f
Author: Roman Sokolkov <email address hidden>
Date: Thu May 26 09:36:27 2016 +0300

    Apply network templates before preupgrade handler

      Controller's "preupgrade" handler replaces
      deployment_info if "isolated". After that
      Octane applies network template.

      But nailgun will NOT apply any new settings
      if replaced_deployment_info exists for node.

      Closes-bug: 1572240

    Change-Id: I06922a59a5f6976acb7c268460fb95fcde86aa54
    (cherry picked from commit 62f75c10445a3cd275c86dae8028e8f444ef1968)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/332931

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/mitaka)
Download full text (40.5 KiB)

Reviewed: https://review.openstack.org/332931
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=24f3c396612eb0c69fbf06bab3cebbb9ca829426
Submitter: Jenkins
Branch: stable/mitaka

commit b34d749f1c281dafbdbf155bd86830dc8f2a9aa2
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 21:10:56 2016 +0300

    Support mock==1.8.0 in unit tests

    Use assert_called_once_with instead of assert_called_once that was
    introduced in 2.0.0.

    Change-Id: Ifb7699d4b552d148984961727355f0e23b487c7c

commit d60f1905143bb7576ffd670595de1c4aeafd7b34
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 02:01:52 2016 +0300

    Allow to authorize by the predefined admin_token

    The admin_token_auth middleware is added to keystone pipelines to
    allow authorization by admin_token.

    Change-Id: Ic03150305a669fad1446436a68051fb9aa25b892

commit cc7fab59f44ffef60285f8732d798f52469b2530
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:47:01 2016 +0300

    Reset default_domain_id before the keystone task

    The default_domain_id should be removed from keystone.conf after restore
    of DB and before to apply the keystone puppet task to avoid of using the
    configured domain as a default.

    Change-Id: I05a6c48532e8042496b3d8ccef53d65bf8c44653

commit e3f82399d567dbcfc1ae9a1ecbddba7bf5028fc8
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:32:47 2016 +0300

    Add helper function to iterate over parameters

    The helpers.iterate_parameters function allows to iterate over lines of
    INI-like files along with a context of information, such section,
    parameter and value.

    Change-Id: I55b179118116fd5dacf100754057ea6589782dc2

commit 5ed370a4fbb3369d0f75873d205ac7f0c655f93a
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:18:05 2016 +0300

    Add update_file context manager for local files

    The subprocess.update_file function provides an ability to update
    content of a local file by iterating over lines of an original file and
    forming a result content in a temporary file to replace the original
    file in the end. This function is very useful to change configuration
    files.

    Change-Id: I433a5da67887b231400dd63131799019f45c277c

commit 58f31e6c5f408630c42565ee53de6b59457bc84c
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jun 22 14:34:03 2016 +0000

    Escape passwords passed to openstack client

    If special symbols are used in password for 'admin' user in
    OpenStack, octane passes them to command line client as is
    and it breaks shell.

    Properly escape the password before passing it to subprocess.

    Change-Id: Iad635aec6d5b5cc32975937e00205b7e89dc99d9
    Closes-bug: 1585960

commit 896aba1191eeb59cf85cc8be6a2ae67e08b76070
Author: Yuriy Taraday <email address hidden>
Date: Wed Jun 22 15:28:45 2016 +0300

    Add absolute_import to util/docker.py to avoid local tempfile module

    Closes-Bug: 1595156
    Change-Id: I9484efce6fa7aec1b41cf592f9e9768d85931fa7

commit 46586a62df962b2ce00b5d8a63f6fd34c920a1f4
Author: Oleg Gelbukh <email address hidden>
Date: Thu M...

tags: added: in-stable-mitaka
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.