Fuel for OpenStack

Weak validation for network group update and delete

  1. Series newton
  2. Bug #1484929
Bug #1484929 reported by Aleksey Kasatkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Confirmed
Medium
Fuel Sustaining
Fuel for OpenStack 11.0
Mitaka
Won't Fix
Medium
Fuel Python (Deprecated)
Fuel for OpenStack 9.0
Newton
Confirmed
Medium
Fuel Sustaining
Fuel for OpenStack 10.1

Bug Description

Validation for new NetworkGroupHandler (PUT/DELETE methods) is much simpler than for NovaNetworkConfigurationHandler and NeutronNetworkConfigurationHandler (PUT method). It covers much less number of cases.
So, validation for new NetworkGroupHandler should be strengthened and cover the same cases as for old handlers.

Aleksey Kasatkin (alekseyk-ru)
Changed in fuel:
assignee: nobody → Fuel Python Team (fuel-python)
Elena Kosareva (ekosareva)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Elena Kosareva (ekosareva)
Elena Kosareva (ekosareva)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/214932

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/214932
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=62cf7b295a191232d0968ce1a0f488671ba379fe
Submitter: Jenkins
Branch: master

commit 62cf7b295a191232d0968ce1a0f488671ba379fe
Author: ekosareva <email address hidden>
Date: Thu Aug 20 02:24:00 2015 +0400

    Make strengthened validation for NetworkGroupHandler

    Validation for new NetworkGroupHandler covers much less number of cases
    than NeutronNetworkConfigurationHandler. Make validation for NetworkGroupHandler
    is more strengthened and cover the same cases as for old handlers.

    Change-Id: I87b26ef28c2acb74cdd4d318044e29ab7aa590d1
    Closes-Bug: #1484929

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

Two more points:
1. NetworkGroupHandler is not covered with JSON schema.
2. CheckNetworks is not called for NetworkGroupHandler.

Changed in fuel:
status: Fix Committed → Confirmed
assignee: Elena Kosareva (ekosareva) → Fuel Python Team (fuel-python)
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

It does not break deployment. And validation is present partly. So, its priority can be lowered.

Changed in fuel:
importance: High → Medium
milestone: 7.0 → 8.0
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Dmitry Pyzhov (dpyzhov)
tags: added: feature-nodegroup team-network
Changed in fuel:
milestone: 8.0 → 9.0
Revision history for this message
Bug Checker Bot (bug-checker) wrote : Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info
Nastya Urlapova (aurlapova)
tags: added: keep-in-9.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/307624

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/307624
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5263334f4f790d21e784e5424029b81445522c57
Submitter: Jenkins
Branch: master

commit 5263334f4f790d21e784e5424029b81445522c57
Author: Aleksey Kasatkin <email address hidden>
Date: Tue Apr 19 10:55:35 2016 +0300

    Fix minor comments in NetworkGroup API code request

    Fix for comments in https://review.openstack.org/#/c/201217/12

    1. Add schema validation into NetworkGroup API validator.
    2. Slight refactoring of objects.NetworkGroup methods.
    3. Fix name of the test in unit/test_migration_fuel_7_0.TestStringNetworkGroupName
    And fix corresponding tests in unit/test_network_group_handler

    Change-Id: If2863c2bbf270f85a74cc784fa06844d710feb4d
    Closes-Bug: #1477648
    Related-Bug: #1484929

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 10.0 → 11.0
assignee: Registry Administrators (registry) → Fuel Sustaining (fuel-sustaining-team)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.