Fuel for OpenStack

tasks adaptation engine is false-negative prone to graph acyclic checks

  1. Series mitaka
  2. Bug #1630556
Bug #1630556 reported by Vladimir Kuklin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Vladimir Kuklin
Fuel for OpenStack 10.0
Mitaka
Fix Committed
High
Vladimir Kuklin
Fuel for OpenStack 9.2
Newton
Fix Committed
High
Vladimir Kuklin
Fuel for OpenStack 10.0

Bug Description

Since Fuel 9.0

adapt legacy tasks adapter calls is_acyclic check for the set of tasks which includes groups which are not then included into task based deployment processing this triggers false-positive errors and fails the deployment. In meanwhile we have Tarjan-based cycle checker in Astute which strips off all the unneeded things and processes properly with any type of valid graphs. Thus, we need to remove cycle check in legacy tasks adapter as it is redundant and error-prone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/382370

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/382371

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/382370
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=46abb99a39923b860f5de787fe39a918ea141f12
Submitter: Jenkins
Branch: master

commit 46abb99a39923b860f5de787fe39a918ea141f12
Author: Vladimir Kuklin <email address hidden>
Date: Wed Oct 5 15:17:08 2016 +0300

    Remove redundant role based graph cycle checker

    This commit removes redundant premature graph cycle checker as
    triggers a false-positive exception during conversion or role-based
    graph into task-based as it should be firstly preprocessed with sorting
    things into several stages, e.g. pre-/post- and deployment stage itself
    later. At the same time we have cycle checker in Astute which also does
    some graph pre-processing and does not trigger on cycles between
    'virtual tasks such as groups

    Change-Id: If6a23ca2b924bac308c19d374044de039e370b46
    Closes-bug: #1630556

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/409113

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/382371
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=e792e5111c2cb58c1b876e679dff43f92ca344b7
Submitter: Jenkins
Branch: stable/mitaka

commit e792e5111c2cb58c1b876e679dff43f92ca344b7
Author: Vladimir Kuklin <email address hidden>
Date: Wed Oct 5 15:17:08 2016 +0300

    Remove redundant role based graph cycle checker

    This commit removes redundant premature graph cycle checker as
    triggers a false-positive exception during conversion or role-based
    graph into task-based as it should be firstly preprocessed with sorting
    things into several stages, e.g. pre-/post- and deployment stage itself
    later. At the same time we have cycle checker in Astute which also does
    some graph pre-processing and does not trigger on cycles between
    'virtual tasks such as groups

    Change-Id: If6a23ca2b924bac308c19d374044de039e370b46
    Closes-bug: #1630556

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/newton)

Reviewed: https://review.openstack.org/409113
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=711c69be94ac132b14574ebea100fad93b4bce24
Submitter: Jenkins
Branch: stable/newton

commit 711c69be94ac132b14574ebea100fad93b4bce24
Author: Vladimir Kuklin <email address hidden>
Date: Wed Oct 5 15:17:08 2016 +0300

    Remove redundant role based graph cycle checker

    This commit removes redundant premature graph cycle checker as
    triggers a false-positive exception during conversion or role-based
    graph into task-based as it should be firstly preprocessed with sorting
    things into several stages, e.g. pre-/post- and deployment stage itself
    later. At the same time we have cycle checker in Astute which also does
    some graph pre-processing and does not trigger on cycles between
    'virtual tasks such as groups

    Change-Id: If6a23ca2b924bac308c19d374044de039e370b46
    Closes-bug: #1630556
    (cherry picked from commit 3ed02d53433183afa3bc957b7155a7699f48dc1e)

Revision history for this message
Vladimir Khlyunev (vkhlyunev) wrote :

How this can be verified? It looks like refactoring task, not bug

tags: added: dev-to-verify
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 11.0.0.0rc1

This issue was fixed in the openstack/fuel-web 11.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.