[octane] lnx_add_port doesn't add permanent configuration

Bug #1576150 reported by Roman Sokolkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Oleg S. Gelbukh
7.0.x
Won't Fix
Medium
Registry Administrators
8.0.x
Fix Committed
Medium
Oleg S. Gelbukh
Mitaka
Fix Committed
Medium
Oleg S. Gelbukh
Newton
Fix Committed
Medium
Oleg S. Gelbukh

Bug Description

After reboot all changes from "lnx_add_port" will be lost.

Steps to reproduce:
1) Upgrade controller to 8.0 (upgrade-node)
2) Swtch to new controller (upgrade-control)
3) Reboot controller

Expected result:
Management and Public IPs of controller are pingable from other node

Actual result:
Management and Public IPs of controller are NOT pingable from other node

Affected versions: 7.0, 8.0, master

Revision history for this message
Ilya Kharin (akscram) wrote :

Could you describe your environment, e.g. how much upgraded controllers do you have?

Ilya Kharin (akscram)
Changed in fuel:
assignee: nobody → Fuel Octane (fuel-octane-team)
status: New → Confirmed
Revision history for this message
Oleg S. Gelbukh (gelbuhos) wrote :

This bug affects only the primary controller of the upgraded environment. Remaining two controllers are installed with the standard persistent interfaces configuration. The workaround for the issue is relatively simple and HA configuration of the OpenStack cluster leaves room to apply it in case of unexpected reboot of the primary controller.

Thus I believe that the severity of this bug should be adjusted to Medium.

Revision history for this message
Oleg S. Gelbukh (gelbuhos) wrote :

The following function should be fixed to provide persistence of the port:

https://github.com/openstack/fuel-octane/blob/master/octane/helpers/network.py#L303-L311

The function mentioned initially in the bug (lnx_add_port) is obsolete and not actually used in the code anymore.

tags: added: non-release
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/323767

Changed in fuel:
assignee: Fuel Octane (fuel-octane-team) → Oleg S. Gelbukh (gelbuhos)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (master)

Fix proposed to branch: master
Review: https://review.openstack.org/323768

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/323767
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=138ebacebc65de61c474a71449bcf32d0f161346
Submitter: Jenkins
Branch: master

commit 138ebacebc65de61c474a71449bcf32d0f161346
Author: Oleg Gelbukh <email address hidden>
Date: Tue May 31 11:35:38 2016 +0000

    Move network utils to util/network.py module

    Currently network.py utility module lives under helpers/ module.
    Move the module to util/ and update imports.

    Change-Id: Ia9adc2185f2b9d2296954856fb37a0b9608bd9c3
    Related-bug: 1576150

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/326508

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/332726

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/332931

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/mitaka)
Download full text (40.5 KiB)

Reviewed: https://review.openstack.org/332931
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=24f3c396612eb0c69fbf06bab3cebbb9ca829426
Submitter: Jenkins
Branch: stable/mitaka

commit b34d749f1c281dafbdbf155bd86830dc8f2a9aa2
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 21:10:56 2016 +0300

    Support mock==1.8.0 in unit tests

    Use assert_called_once_with instead of assert_called_once that was
    introduced in 2.0.0.

    Change-Id: Ifb7699d4b552d148984961727355f0e23b487c7c

commit d60f1905143bb7576ffd670595de1c4aeafd7b34
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 02:01:52 2016 +0300

    Allow to authorize by the predefined admin_token

    The admin_token_auth middleware is added to keystone pipelines to
    allow authorization by admin_token.

    Change-Id: Ic03150305a669fad1446436a68051fb9aa25b892

commit cc7fab59f44ffef60285f8732d798f52469b2530
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:47:01 2016 +0300

    Reset default_domain_id before the keystone task

    The default_domain_id should be removed from keystone.conf after restore
    of DB and before to apply the keystone puppet task to avoid of using the
    configured domain as a default.

    Change-Id: I05a6c48532e8042496b3d8ccef53d65bf8c44653

commit e3f82399d567dbcfc1ae9a1ecbddba7bf5028fc8
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:32:47 2016 +0300

    Add helper function to iterate over parameters

    The helpers.iterate_parameters function allows to iterate over lines of
    INI-like files along with a context of information, such section,
    parameter and value.

    Change-Id: I55b179118116fd5dacf100754057ea6589782dc2

commit 5ed370a4fbb3369d0f75873d205ac7f0c655f93a
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:18:05 2016 +0300

    Add update_file context manager for local files

    The subprocess.update_file function provides an ability to update
    content of a local file by iterating over lines of an original file and
    forming a result content in a temporary file to replace the original
    file in the end. This function is very useful to change configuration
    files.

    Change-Id: I433a5da67887b231400dd63131799019f45c277c

commit 58f31e6c5f408630c42565ee53de6b59457bc84c
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jun 22 14:34:03 2016 +0000

    Escape passwords passed to openstack client

    If special symbols are used in password for 'admin' user in
    OpenStack, octane passes them to command line client as is
    and it breaks shell.

    Properly escape the password before passing it to subprocess.

    Change-Id: Iad635aec6d5b5cc32975937e00205b7e89dc99d9
    Closes-bug: 1585960

commit 896aba1191eeb59cf85cc8be6a2ae67e08b76070
Author: Yuriy Taraday <email address hidden>
Date: Wed Jun 22 15:28:45 2016 +0300

    Add absolute_import to util/docker.py to avoid local tempfile module

    Closes-Bug: 1595156
    Change-Id: I9484efce6fa7aec1b41cf592f9e9768d85931fa7

commit 46586a62df962b2ce00b5d8a63f6fd34c920a1f4
Author: Oleg Gelbukh <email address hidden>
Date: Thu M...

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/332726
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=6504fb25b6b525e0d43d375f9daa4c43a87c5385
Submitter: Jenkins
Branch: master

commit 6504fb25b6b525e0d43d375f9daa4c43a87c5385
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jun 22 10:08:16 2016 +0000

    Move test for update file to module tests/util.py

    Refactor tests for updating files on the node for later
    reuse in testing of update of /etc/network/interfaces
    file for persisting the interface created by the
    control plane cut-over.

    Change-Id: Ic65a69a0c2ef442b8d0e3d20b05db639a63fca7c
    Related-bug: 1576150

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/8.0)

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/333214

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/333214
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=92200593f0e828bae4c2de21d940fc5635f8122b
Submitter: Jenkins
Branch: stable/8.0

commit 92200593f0e828bae4c2de21d940fc5635f8122b
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jun 22 10:08:16 2016 +0000

    Move test for update file to module tests/util.py

    Refactor tests for updating files on the node for later
    reuse in testing of update of /etc/network/interfaces
    file for persisting the interface created by the
    control plane cut-over.

    Change-Id: Ic65a69a0c2ef442b8d0e3d20b05db639a63fca7c
    Related-bug: 1576150
    (cherry picked from commit 6504fb25b6b525e0d43d375f9daa4c43a87c5385)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/323768
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=9912cdc6030d13f140c3f63cd1c34ec497404e07
Submitter: Jenkins
Branch: master

commit 9912cdc6030d13f140c3f63cd1c34ec497404e07
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jun 22 10:11:20 2016 +0000

    Save port membership for patch interface

    Patch interface added to Linux bridge during the control plane
    cutover, but not saved to configuration file for persistence.

    Add function to add port to bridge's configuration.

    Change-Id: If40bebf384b24d6af5e42798fbf6bc2993dc4795
    Closes-bug: 1576150

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/8.0)

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/338241

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/338242

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/338241
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=81ea2737ca4acd632d41b3caaf5bba585e88063d
Submitter: Jenkins
Branch: stable/8.0

commit 81ea2737ca4acd632d41b3caaf5bba585e88063d
Author: Oleg Gelbukh <email address hidden>
Date: Tue May 31 11:35:38 2016 +0000

    Move network utils to util/network.py module

    Currently network.py utility module lives under helpers/ module.
    Move the module to util/ and update imports.

    Change-Id: Ia9adc2185f2b9d2296954856fb37a0b9608bd9c3
    Related-bug: 1576150
    (cherry picked from commit 138ebacebc65de61c474a71449bcf32d0f161346)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/338242
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=17ee4b47129329d57796fc8c93c90c6313c5da55
Submitter: Jenkins
Branch: stable/8.0

commit 17ee4b47129329d57796fc8c93c90c6313c5da55
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jun 22 10:11:20 2016 +0000

    Save port membership for patch interface

    Patch interface added to Linux bridge during the control plane
    cutover, but not saved to configuration file for persistence.

    Add function to add port to bridge's configuration.

    Change-Id: If40bebf384b24d6af5e42798fbf6bc2993dc4795
    Closes-bug: 1576150
    (cherry picked from commit 9912cdc6030d13f140c3f63cd1c34ec497404e07)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-octane (master)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/326508
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (master)

Fix proposed to branch: master
Review: https://review.openstack.org/351721

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-octane (master)

Change abandoned by Ilya Kharin (<email address hidden>) on branch: master
Review: https://review.openstack.org/351721
Reason: This patch have to go in stable/mitaka instead of master.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/351728

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/mitaka)
Download full text (17.8 KiB)

Reviewed: https://review.openstack.org/351728
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=3101bf302ea0f2d501fd42a6ae6046c3587ac093
Submitter: Jenkins
Branch: stable/mitaka

commit a05d2ecf13e15c12f10e1517fae425e583e0d714
Author: Nikita Zubkov <email address hidden>
Date: Thu Aug 4 17:51:56 2016 +0300

    fix ssh connection auth

    According to spec [1] service user must use key authentication​ for ssh

    [1] https://github.com/openstack/fuel-specs/blame/ba4504/specs/9.0/fuel-nonroot-openstack-nodes.rst#L61-L64

    Change-Id: I461f659d4f0985283a43ec6a702bdd78af91a072

commit 7140398e501879a4e1f5605f3d1cc99195464850
Author: Sergey Abramov <email address hidden>
Date: Tue Aug 2 12:12:57 2016 +0300

    Setup upgrade levels for each fuel version

    Setup upgrade levels block in nova.conf for each fuel version,
    this is required for backward compatibility on RPC.

    Change-Id: I6ccbc34457d11616b015cdb1e46e733b0b49ce58

commit 9e2a419ac79ad591faee9afe16419bf4497eacad
Author: Vladimir Khlyunev <email address hidden>
Date: Mon Aug 1 21:31:56 2016 +0300

    Fix several typos

    Copypasting is evil, lets remove typos

    Change-Id: Icf4bec1a3de954911a469fa98380af2b6175da08

commit 013a7ded2275245a38ee58289dac2bc8b90fa37e
Author: Sergey Abramov <email address hidden>
Date: Wed Jul 20 16:05:10 2016 +0300

    Host evacuation using nova

    Evacuate instance from compute node using
    nova host-evacuate-live except host_evacuation.sh script

    Change-Id: I01a04cfa1ed2aafce7987e523e6b589dea21fbb0

commit 00a1d0dce1f7ae5db6706a59353403516f7913dc
Author: Sergey Abramov <email address hidden>
Date: Tue Jul 19 17:10:44 2016 +0300

    Change shutoff vm command

    * run nova commands using nova util function
    * host filter using get nova node handle method(
        hostname for fuel < 6.1 and fqdn for newer version)

    Change-Id: Ib5c373714e359982b13910a225787167db7b35e9

commit 49357c98313c5f551b13d0877581c5fb5e108db1
Author: Nikita Zubkov <email address hidden>
Date: Mon Jun 27 18:40:13 2016 +0300

    Add `stderr_log_level` parameter to popen

    Now posible to set logging level in popen for logging stderr

    fuel-bootstrap build comand stderr now logged with INFO level

    Change-Id: Ibaa2be54c68ce7a428e07052c917f54e99b95a5e

commit fb582b271dab4bdd10d27149a77c0e1f6a580b9e
Author: Sergey Abramov <email address hidden>
Date: Thu Jul 21 17:56:41 2016 +0300

    Add run_nova_cmd function

    This is required for running nova command on contoller without
    manipulating manipulating with command.

    It makes code easier and more readable

    Usage:

        from fuelclient.objects import environment as environment_obj

        from octane.util import env
        from octane.util import nova

        env_id = ...
        my_env = environment_obj.Environment(env_id)
        controller = env.get_one_controller(my_env)
        nova_cmd_just_run = [...]
        nova_cmd_with_output = [...]
        nova.run_nova_cmd(nova_cmd_just_run, controller, False)
        result = nova.run_nova_cmd(nova_cmd_w...

Revision history for this message
Rodion Tikunov (rtikunov) wrote :

Closing as Won't Fix for 7.0 as this is a medium importance non-customer-found bug.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.