Fuel for OpenStack

Roles are hardcoded in ntp task

  1. Series mitaka
  2. Bug #1563465
Bug #1563465 reported by Dmitry Ukov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Kyrylo Galanov
Fuel for OpenStack 10.0
Mitaka
Fix Committed
Medium
Stanislaw Bogatkin
Fuel for OpenStack 9.2

Bug Description

We should not use hardcoded role names (primary-controller and controller) in ntp-client task
See: https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/manifests/ntp/ntp_client.pp#L8

Hiera parameter should be used in order to provide ability to override it from plugin

Roman Prykhodchenko (romcheg)
summary: - Roles hardcode in ntp task
+ Roles are hardcoded in ntp task
tags: added: area-library
tags: added: tech-debt
Changed in fuel:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Fuel Library Team (fuel-library)
milestone: none → 9.0
Kyrylo Galanov (kgalanov)
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Kyrylo Galanov (kgalanov)
Kyrylo Galanov (kgalanov)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/300297

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/300297
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=776a17dd946b4782991b156d3e6b7fbdfa2bf817
Submitter: Jenkins
Branch: master

commit 776a17dd946b4782991b156d3e6b7fbdfa2bf817
Author: Kyrylo Galanov <email address hidden>
Date: Fri Apr 1 05:53:24 2016 +0200

    Remove hardcoded NTP server role names

    NTP server roles can be overriden.

    Change-Id: Ib75dd9e2d1baac6c23489ac5b365bb643728d737
    DocImpact: New paratemer ntp_server_roles
    Closes-bug: #1563465

Changed in fuel:
status: In Progress → Fix Committed
Maria Zlatkova (mzlatkova)
tags: added: release-notes
Maria Zlatkova (mzlatkova)
tags: added: release-notes-done
removed: release-notes
Revision history for this message
Alex Schultz (alex-schultz) wrote :

this change is in 10 not 9

Changed in fuel:
milestone: 9.0 → 10.0
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

We don't backport medium priority bugs

Revision history for this message
Olena Logvinova (ologvinova) wrote :

Since the bug description was removed from 9.0 RN (https://review.fuel-infra.org/#/c/22385, https://bugs.launchpad.net/fuel/+bug/1567882), adding it as a known issue to 9.1 RN (https://review.fuel-infra.org/#/c/27240/).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/396176

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/396176
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=edf32ea9e93901c9aa4af174c1f24ec759b40ad3
Submitter: Jenkins
Branch: stable/mitaka

commit edf32ea9e93901c9aa4af174c1f24ec759b40ad3
Author: Kyrylo Galanov <email address hidden>
Date: Fri Apr 1 05:53:24 2016 +0200

    Remove hardcoded NTP server role names

    NTP server roles can be overriden.

    Change-Id: Ib75dd9e2d1baac6c23489ac5b365bb643728d737
    DocImpact: New paratemer ntp_server_roles
    Closes-bug: #1563465
    (cherry picked from commit 776a17dd946b4782991b156d3e6b7fbdfa2bf817)

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix proposed to mos/mos-docs (master)

Related fix proposed to branch: master
Change author: Mariia Zlatkova <email address hidden>
Review: https://review.fuel-infra.org/30303

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to mos/mos-docs (master)

Reviewed: https://review.fuel-infra.org/30303
Submitter: Olena Logvinova <email address hidden>
Branch: master

Commit: dc4cfe1141c0237b04d32ddea8c33b09ac0f854d
Author: Mariia Zlatkova <email address hidden>
Date: Thu Feb 2 13:50:37 2017

[RN-9.2] Fuel resolved and known issues

Change-Id: Idb919f92b981eee0f2cb48618dde243e4582ee5b
Related-Bug: #1590633
Related-Bug: #1625293
Related-Bug: #1561092
Related-Bug: #1619341
Related-Bug: #1563465
Related-Bug: #1628500
Related-Bug: #1593277
Related-Bug: #1628940
Related-Bug: #1658952

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix proposed to mos/mos-docs (stable/9.2)

Related fix proposed to branch: stable/9.2
Change author: Mariia Zlatkova <email address hidden>
Review: https://review.fuel-infra.org/30423

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to mos/mos-docs (stable/9.2)

Reviewed: https://review.fuel-infra.org/30423
Submitter: Mariia Zlatkova <email address hidden>
Branch: stable/9.2

Commit: c040581a57fac1dfeaed44952359f21963216d62
Author: Mariia Zlatkova <email address hidden>
Date: Thu Feb 2 14:03:50 2017

[RN-9.2] Fuel resolved and known issues

Change-Id: Idb919f92b981eee0f2cb48618dde243e4582ee5b
Related-Bug: #1590633
Related-Bug: #1625293
Related-Bug: #1561092
Related-Bug: #1619341
Related-Bug: #1563465
Related-Bug: #1628500
Related-Bug: #1593277
Related-Bug: #1628940
Related-Bug: #1658952
(cherry picked from commit dc4cfe1141c0237b04d32ddea8c33b09ac0f854d)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.