[8.0-pkg-pipeline-ubuntu][OS components] Build should fail in case of different versions in changelog and last tag

Bug #1495406 reported by Ivan Udovichenko
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Alexey Golubev
Mitaka
Fix Committed
High
Alexey Golubev

Bug Description

Build should fail if provided version in debian/changelog and last tag in OpenStack component code differs significantly.

Revision history for this message
Dmitry Burmistrov (dburmistrov) wrote :

Please formalize conditions to failure.

Changed in fuel:
status: Confirmed → Incomplete
Revision history for this message
Ivan Udovichenko (iudovichenko) wrote :

For example: 2015.2 and 7.0.0 versions differ, in this case build job should fail.
7.0.0 and 7.0.1 versions differ and the job should fail.
You can check the version in Debian for example, how the tag and version differ.

Changed in fuel:
status: Incomplete → Confirmed
Revision history for this message
Dmitry Burmistrov (dburmistrov) wrote :

According to change-request comment
>Also at this moment only 3 digits is a good idea to use.
>For example 7.0.0.0b3, only 7.0.0 is a good idea to use and compare to package version.
please formalize conditions
All tag list for each openstack project you can find at review.openstack.org
Example for nova project: https://review.openstack.org/gitweb?p=openstack/nova.git;a=tags

Changed in fuel:
status: Confirmed → Incomplete
Revision history for this message
Ivan Udovichenko (iudovichenko) wrote :

Compare first 3 digits:
x.x.x

Changed in fuel:
status: Incomplete → Confirmed
Revision history for this message
Dmitry Burmistrov (dburmistrov) wrote :

Not all tags match template "x.x.x". Please describe rules for all available tag formats.

Changed in fuel:
status: Confirmed → Incomplete
Revision history for this message
Roman Vyalov (r0mikiam) wrote :

i think we can add additional test in our packaging ci for this issue. but we need clear description for this task. At the moment openstack package version automatically generated from gerrit tag and CI add information about version to the package changelog. because of this we need more information why and how we can implement this test ?

Revision history for this message
Ivan Udovichenko (iudovichenko) wrote :

Take only tags with numbers and ignore other cases. Please put some time in finding the best solution as you have far more experience in maintaining build systems in our company and know all its bottlenecks.
Thank you for your time and great work.

Changed in fuel:
status: Incomplete → Confirmed
Revision history for this message
Vladimir Kozhukalov (kozhukalov) wrote :

Until there is clear requirement for the issue, it is incomplete. Ivan, please give formal criteria. Probably that is more CI related issue rather than build related one. So changing to Incomplete (AGAIN) and re-assigning to fuel-ci.

Changed in fuel:
assignee: Fuel build team (fuel-build) → Fuel CI team (fuel-ci)
status: Confirmed → Incomplete
Revision history for this message
Ivan Udovichenko (iudovichenko) wrote :

Hello Vladimir,
What other criteria do you need ? It ment to be a simple check.
Follow the pattern and ignore all other cases.
It will prevent from sudden changes to the code.
I'd be glad if you share your concerns in details.

Changed in fuel:
importance: High → Wishlist
status: Incomplete → Confirmed
importance: Wishlist → Medium
Dmitry Pyzhov (dpyzhov)
tags: added: area-ci
Revision history for this message
Aleksandra Fedorova (bookwar) wrote :

This test should be part of build scripts, not a separate CI job.

Build team please check if you can implement it

Changed in fuel:
assignee: Fuel CI team (fuel-ci) → Fuel build team (fuel-build)
Dmitry Pyzhov (dpyzhov)
tags: added: area-build
removed: area-ci
Roman Vyalov (r0mikiam)
tags: added: perestroika
Roman Vyalov (r0mikiam)
tags: added: move-to-prod
Roman Vyalov (r0mikiam)
Changed in fuel:
milestone: 8.0 → 9.0
Roman Vyalov (r0mikiam)
tags: added: feature
removed: perestroika tag
Revision history for this message
Dmitry Burmistrov (dburmistrov) wrote :

IMO this activity doesn't related neither build nor install test stage. It shoul be separate CI check started before build stage

Revision history for this message
Alexander Tsamutali (astsmtl) wrote :

Our requirements are simple. As Roman said build system infers version from source code and updates spec/debian with this version. Instead of updating, please check if spec/debian _already contains_ inferred version. If not - fail build.

Changed in fuel:
assignee: Fuel build team (fuel-build) → Alexey Golubev (agolubev)
Changed in fuel:
importance: Medium → High
Revision history for this message
Ivan Udovichenko (iudovichenko) wrote :

Increasing the bug priority due to related issues: https://bugs.launchpad.net/fuel/+bug/1565630

Roman Vyalov (r0mikiam)
tags: removed: debian move-to-prod
tags: removed: build changelog
Revision history for this message
Alexey Golubev (agolubev) wrote :

Bug priority should be reverted to Medium, due to invalidity of the issue, mentioned above (https://bugs.launchpad.net/fuel/+bug/1565630)

Revision history for this message
Ivan Udovichenko (iudovichenko) wrote :

The bug itself is valid, the chaos was proposed by this commit https://review.fuel-infra.org/18558/ as Dmitry B. found out. And CI automatically generated the latest version from tag. That is why I've raised the priority.

summary: [8.0-pkg-pipeline-ubuntu][OS components] Build should fail in case of
- differend versions in changelog and last tag
+ different versions in changelog and last tag
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-mirror (master)

Fix proposed to branch: master
Review: https://review.openstack.org/301730

Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
milestone: 9.0 → 10.0
Changed in fuel:
assignee: Alexey Golubev (agolubev) → Sergey Kulanov (skulanov)
Changed in fuel:
assignee: Sergey Kulanov (skulanov) → Alexey Golubev (agolubev)
Roman Vyalov (r0mikiam)
Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-mirror (master)

Reviewed: https://review.openstack.org/301730
Committed: https://git.openstack.org/cgit/openstack/fuel-mirror/commit/?id=fb1850062a4c1ed7a01c3eef7190104109df5f73
Submitter: Jenkins
Branch: master

commit fb1850062a4c1ed7a01c3eef7190104109df5f73
Author: Alexey Golubev <email address hidden>
Date: Tue Apr 5 17:42:28 2016 +0300

    Added version comparison from gerrit tag and changelog

    Build fails if provided version in spec file and the
    last tag in OpenStack component code differs.

    Change-Id: I7e15692c2aacbdde13dea86eae954cb9665e3828
    Closes-Bug: #1495406

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on infra/obs (feature/new-build-system)

Change abandoned by Dmitry Burmistrov <email address hidden> on branch: feature/new-build-system
Review: https://review.fuel-infra.org/11557

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.