Fuel for OpenStack

no failure message when network yaml contains errors

  1. Series 6.1.x
  2. Bug #1469331
Bug #1469331 reported by Andrew Woodward
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
Low
Unassigned
Fuel for OpenStack 8.0
6.1.x
In Progress
High
Alexander Kuleshov
Fuel for OpenStack 6.1-updates
8.0.x
Invalid
Low
Unassigned
Fuel for OpenStack 8.0

Bug Description

If you have parsing, or other logical errors in network yaml during upload they are ignored and a partial update with no failure feedback is performed

steps to repoduce

1. create env
2. download network yaml
3. alter network yaml by [a][b]
4. upload network yaml
5. copy file with changes elsewhere
6. download network yaml
7. compare (diff) proposed and current yaml.

[a] alter the network ip_range for storage, management
[b] change the cidr to 192.168.2900.0/24

expected result:

the fuel api returns an error and message that indicates that the update failed

Alexander Kislitsky (akislitsky)
Changed in fuel:
milestone: none → 7.0
Maciej Kwiek (maciej-iai)
tags: added: cli
Maciej Kwiek (maciej-iai)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Maciej Kwiek (maciej-iai)
Revision history for this message
Andrew Woodward (xarses) wrote :

+customer-found and +feature-nodgroup as it's most likely to be seen then

tags: added: customer-found feature-nodegroup
Aleksandr Didenko (adidenko)
tags: added: feature
removed: feature-nodegroup
tags: added: feature-validation
Revision history for this message
Maciej Kwiek (maciej-iai) wrote :

`raise_task` method does not raise an actual exception, thus returning 200 status, which causes the cli to assume that everything went fine.

I could not reproduce the "partial" update with the error, can you provide me with example yamls that lead to this behavior?

Changed in fuel:
status: Confirmed → Triaged
status: Triaged → In Progress
assignee: Maciej Kwiek (maciej-iai) → Andrew Woodward (xarses)
Maciej Kwiek (maciej-iai)
Changed in fuel:
assignee: Andrew Woodward (xarses) → Maciej Kwiek (maciej-iai)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/207821

Revision history for this message
Maciej Kwiek (maciej-iai) wrote : Re: no failure message when network yaml is partially accepted

It seems that my patch should also fix https://bugs.launchpad.net/fuel/+bug/1423916, change the way UI handles these handlers. It's too much work, I won't be able to merge this before SCF. I will ask to move this bug to 8.0.

Maciej Kwiek (maciej-iai)
Changed in fuel:
assignee: Maciej Kwiek (maciej-iai) → Fuel Python Team (fuel-python)
status: In Progress → Confirmed
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 8.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/210034

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Alexander Kuleshov (akuleshov)
status: Confirmed → In Progress
Revision history for this message
Andrew Woodward (xarses) wrote : Re: no failure message when network yaml is partially accepted

Bump priority because of additional report and customer found status

https://bugs.launchpad.net/fuel/+bug/1483255

Changed in fuel:
importance: Medium → High
milestone: 8.0 → 7.0
Revision history for this message
Przemyslaw Kaminski (pkaminski) wrote :

Relevant discussion why 400 status in network check was removed:
https://review.openstack.org/#/c/137642/15/nailgun/nailgun/api/v1/handlers/network_configuration.py
If you change it back, you will create UI errors: https://review.openstack.org/#/c/161246/
A fix for CLI: https://bugs.launchpad.net/fuel/+bug/1483211
Tasks should be removed from network configuration: https://bugs.launchpad.net/fuel/+bug/1423916

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Alexander Kuleshov (<email address hidden>) on branch: master
Review: https://review.openstack.org/210034
Reason: Addressed by https://review.openstack.org/#/c/211126/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (stable/6.1)

Fix proposed to branch: stable/6.1
Review: https://review.openstack.org/213045

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (stable/6.1)

Change abandoned by Alexander Kuleshov (<email address hidden>) on branch: stable/6.1
Review: https://review.openstack.org/209452
Reason: Addressed by https://review.openstack.org/#/c/213045/

Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote : Re: no failure message when network yaml is partially accepted

Move it to 6.1 because it's already fixed in 7.1.

Changed in fuel:
milestone: 7.0 → 6.1-updates
Andrew Woodward (xarses)
summary: - no failure message when network yaml is partially accepted
+ no failure message when network yaml contains errors
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Maciej Kwiek (<email address hidden>) on branch: master
Review: https://review.openstack.org/207821

Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-fuelclient (stable/6.1)

Change abandoned by Tony Breeds (<email address hidden>) on branch: stable/6.1
Review: https://review.openstack.org/213045
Reason: This branch (stable/6.1) is at End Of Life

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.