Fuel for OpenStack

fix fuel-library unit tests

  1. Series 6.1.x
  2. Bug #1455847
Bug #1455847 reported by Aleksandra Fedorova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
High
MOS Maintenance
Fuel for OpenStack 9.0
6.1.x
In Progress
High
MOS Maintenance
Fuel for OpenStack 6.1-updates
7.0.x
Invalid
Undecided
MOS Maintenance
Fuel for OpenStack 7.0-updates
8.0.x
Invalid
Undecided
MOS Maintenance
Fuel for OpenStack 8.0

Bug Description

Due to request https://bugs.launchpad.net/bugs/1455817 unit tests for fuel-library repo were switched to non-voting mode for 6.1

We need to fix them and enable in 7.0

Aleksandr Didenko (adidenko)
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Aleksandr Didenko (adidenko)
OpenStack Infra (hudson-openstack)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Aleksandr Didenko (adidenko) wrote :

Partial fix https://review.openstack.org/#/c/195625/

Revision history for this message
Aleksandr Didenko (adidenko) wrote :

We also need to fix unit tests for l23network and then we can enable them back into voting mode. Errors in l23network are:

Failures:

  1) function_get_network_role_property mtk should return NIL for "admin" network role
     Failure/Error: should run.with_params('admin', 'phys_dev').and_return(nil)
       expected get_network_role_property("admin", "phys_dev") to have returned nil instead of ["eth0"]
     # ./spec/functions/get_network_role_property__spec.rb:90:in `block (3 levels) in <top (required)>'

  2) function_get_transformation_property get_transformation_property('some_property', 'transformation') usage should return NIL for "eth2" transformation
     Failure/Error: should run.with_params('mtu', 'eth2').and_return(nil)
       expected get_transformation_property("mtu", "eth2") to have returned nil instead of 1024
     # ./spec/functions/get_transformation_property__spec.rb:120:in `block (3 levels) in <top (required)>'

Changed in fuel:
assignee: Aleksandr Didenko (adidenko) → Stanislav Makar (smakar)
Revision history for this message
Stanislav Makar (smakar) wrote :

this happens due to new version of rspec-puppet 2.2.0
with rspec-puppet 2.1.0 and 2.0.1 all is ok

Revision history for this message
Stanislav Makar (smakar) wrote :

Fixes the patch https://review.openstack.org/#/c/197041/

OpenStack Infra (hudson-openstack)
Changed in fuel:
assignee: Stanislav Makar (smakar) → Sergey Vasilenko (xenolog)
OpenStack Infra (hudson-openstack)
Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to fuel-infra/jenkins-jobs (master)

Fix proposed to branch: master
Change author: Alexander Didenko <email address hidden>
Review: https://review.fuel-infra.org/9028

Revision history for this message
Aleksandr Didenko (adidenko) wrote :

Fixes merged, need to switch the job to voting mode:
https://review.fuel-infra.org/9028

Changed in fuel:
assignee: Sergey Vasilenko (xenolog) → Aleksandr Didenko (adidenko)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (stable/6.1)

Related fix proposed to branch: stable/6.1
Review: https://review.openstack.org/219186

Sergey Vilgelm (sergey.vilgelm)
tags: added: on-verification
Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :

This bug is still in progress. The main problem is fixed but the job is not voting yet.

tags: removed: on-verification
Changed in fuel:
status: Fix Committed → In Progress
Vladimir Kuklin (vkuklin)
tags: added: non-release
Igor Shishkin (teran)
Changed in fuel:
milestone: 7.0 → 8.0
Dmitry Pyzhov (dpyzhov)
tags: added: tech-debt
removed: non-release
Revision history for this message
Aleksandr Didenko (adidenko) wrote :

Fix is on review since sept 1, please merge it:
https://review.openstack.org/#/c/219186/

Forwarding to maintenance team.

Changed in fuel:
assignee: Aleksandr Didenko (adidenko) → MOS Maintenance (mos-maintenance)
tags: added: fuel-ci
Revision history for this message
Aleksandr Didenko (adidenko) wrote :

Clarification:
https://review.openstack.org/#/c/219186/ fixes unti tests for 6.1, after that we can switch jobs to voting mode for all branches
https://review.fuel-infra.org/#/c/9028/ switches unit test jobs to voting mode

Revision history for this message
Vitaly Sedelnik (vsedelnik) wrote :

The reviews above have no CR+2

Dmitry Pyzhov (dpyzhov)
tags: added: area-ci
Aleksandra Fedorova (bookwar)
Changed in fuel:
milestone: 8.0 → 6.1-updates
Fuel Devops McRobotson (fuel-devops-robot)
Changed in fuel:
milestone: 6.1-updates → 9.0
status: In Progress → New
Revision history for this message
Denis Meltsaykin (dmeltsaykin) wrote :

This bugreport is regarding 6.1, other milestones here are Invalid.

Changed in fuel:
status: New → Invalid
no longer affects: fuel/future
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on fuel-infra/jenkins-jobs (master)

Change abandoned by Alexander Didenko <email address hidden> on branch: master
Review: https://review.fuel-infra.org/9028
Reason: Outdated

Sergii Rizvan (srizvan)
tags: added: non-release
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (stable/6.1)

Change abandoned by Aleksandr Didenko (<email address hidden>) on branch: stable/6.1
Review: https://review.openstack.org/219186
Reason: It looks like it's no longer needed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.