Issues with clearing routers in OSTF tests

Bug #1419025 reported by Sebastian Kalinowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Tatyanka
6.0.x
Fix Committed
High
Tatyanka

Bug Description

When running OSTF tests with Neutron network there are errors appearing in ostf log:

2015-02-06 13:20:53 DEBUG (neutronmanager) Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/fuel_health/neutronmanager.py", line 124, in _clear_networks
    cls._remove_router(router, cls.routers[router])
TypeError: unbound method _remove_router() must be called with TestNeutron instance as first argument (got unicode instance instead)

2015-02-06 13:20:53 DEBUG (neutronmanager) Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/fuel_health/neutronmanager.py", line 131, in _clear_networks
    cls._remove_subnet(subnet)
TypeError: unbound method _remove_subnet() must be called with TestNeutron instance as first argument (got dict instance instead)

2015-02-06 13:20:53 DEBUG (neutronmanager) Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/fuel_health/neutronmanager.py", line 138, in _clear_networks
    cls._remove_network(network)
TypeError: unbound method _remove_network() must be called with TestNeutron instance as first argument (got dict instance instead)

This is because wrong this _clear_network [1] which is a classmethod calls instance methods [2]. This may cause to pollute environment with routers, networks and subntes created in OSTF tests.

[1] https://github.com/stackforge/fuel-ostf/blob/6c046b69d29021524906109f18092363505ee222/fuel_health/neutronmanager.py#L119-L120
[2] https://github.com/stackforge/fuel-ostf/blob/6c046b69d29021524906109f18092363505ee222/fuel_health/neutronmanager.py#L104-L117

Tags: ostf
Changed in fuel:
status: New → Confirmed
Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Tatyanka (tatyana-leontovich)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ostf (master)

Fix proposed to branch: master
Review: https://review.openstack.org/168322

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ostf (master)

Reviewed: https://review.openstack.org/168322
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=e59c905566ed701117d7c643b435b13e6b5f8c3b
Submitter: Jenkins
Branch: master

commit e59c905566ed701117d7c643b435b13e6b5f8c3b
Author: Tatyana Leontovich <email address hidden>
Date: Fri Mar 27 14:42:35 2015 +0200

    Add teardown into neutron manager

    Add teardown into neutron manager

    Change-Id: Icb1fec7f08029f70c5d101df78c9bb0d3e56b720
    Closes-Bug: #1419025

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ostf (stable/6.0)

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/168377

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ostf (stable/6.0)

Reviewed: https://review.openstack.org/168377
Committed: https://git.openstack.org/cgit/stackforge/fuel-ostf/commit/?id=57c4e560b8426ce51ce3f992b16a55e792989d94
Submitter: Jenkins
Branch: stable/6.0

commit 57c4e560b8426ce51ce3f992b16a55e792989d94
Author: Tatyana Leontovich <email address hidden>
Date: Fri Mar 27 14:42:35 2015 +0200

    [stable/6.0]Add teardown into neutron manager

    Add teardown into neutron manager

    Change-Id: Icb1fec7f08029f70c5d101df78c9bb0d3e56b720
    Closes-Bug: #1419025
    (cherry picked from commit e59c905566ed701117d7c643b435b13e6b5f8c3b)

Revision history for this message
Tatyanka (tatyana-leontovich) wrote :

verified on iso 329

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.