Fuel for OpenStack

supervisord don't really monitor cobbler container

  1. Series 5.1.x
  2. Bug #1393342
Bug #1393342 reported by Sergey Vasilenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Matthew Mosesohn
Fuel for OpenStack 6.0
5.1.x
Fix Committed
High
Matthew Mosesohn
Fuel for OpenStack 5.1.1

Bug Description

supervisord don't really monitor cobbler container

Container may be dead, but supervisord don't know about it.

6.0 ISO #109, #110

screenshot:

https://www.dropbox.com/s/5sjc1fgvj8o83pt/Screenshot%202014-11-17%2012.18.59.png?dl=0

Tags: cobbler docker
Revision history for this message
Sergey Vasilenko (xenolog) wrote :

Diagnostic snapshop can't be attached, because:
https://www.dropbox.com/s/yku7ohf3ovn9e15/Screenshot%202014-11-17%2012.29.02.png?dl=0

Bogdan Dobrelya (bogdando)
Changed in fuel:
importance: Undecided → High
assignee: nobody → Fuel Library Team (fuel-library)
status: New → Confirmed
Matthew Mosesohn (raytrac3r)
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Matthew Mosesohn (raytrac3r)
Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

It's just the workflow of dockerctl start --attach containername. It should only attach to process and skip all the check steps that halt it. The container does restart after all 4 checks pass. It's just that it takes 32 minutes for all checks to time out.
I'll tackle this on two fronts:
1 - combine checks down to 2
2 - skip automatic "check_ready" when we run with --attach option.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134905

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/5.1)

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/137005

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/134905
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=68ef000b8cab70f56944040afcf7d5d0e5f34bbf
Submitter: Jenkins
Branch: master

commit 68ef000b8cab70f56944040afcf7d5d0e5f34bbf
Author: Matthew Mosesohn <email address hidden>
Date: Mon Nov 17 14:15:28 2014 +0400

    Fix behavior when running dockerctl start --attach

    --attach option skips check_ready steps, which would only
    run after a container was killed. This led to unnecessary
    checks that were run when the container is stopped. Now the
    program exits quickly so supervisor can restart the container
    as intended.

    Additionally, consolidated cobbler checks so that it fails in
    16 minutes intead of 32.

    Change-Id: I4d3c6e20b8dec0d11af46080fe6941b6b34cae4a
    Closes-Bug: #1393342

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/5.1)

Reviewed: https://review.openstack.org/137005
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=3c7855027192dbcfa330a664174830d2dae0953b
Submitter: Jenkins
Branch: stable/5.1

commit 3c7855027192dbcfa330a664174830d2dae0953b
Author: Matthew Mosesohn <email address hidden>
Date: Mon Nov 17 14:15:28 2014 +0400

    Fix behavior when running dockerctl start --attach

    --attach option skips check_ready steps, which would only
    run after a container was killed. This led to unnecessary
    checks that were run when the container is stopped. Now the
    program exits quickly so supervisor can restart the container
    as intended.

    Additionally, consolidated cobbler checks so that it fails in
    16 minutes intead of 32.

    Change-Id: I4d3c6e20b8dec0d11af46080fe6941b6b34cae4a
    Closes-Bug: #1393342
    (cherry picked from commit 68ef000b8cab70f56944040afcf7d5d0e5f34bbf)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.