Node Discovery Information being overwritten

Issue:
Node Discovery Behavior

Synopsis:
1. “Name” assigned to the node on the discovery is not unique.
2. Node discovery information gets overwritten against the same “Name” and “Id”.
3. “Id” and “name” get updated with the information from the first node discovery after a node delete and stick to that thereafter.

Issue Re-production procedure:
1. Initial status on the fuel node listing.
[root@fuel ~]# fuel2 node list
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
| id | name | status | os_platform | roles | ip | mac | cluster | platform_name | online |
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
| 1 | Untitled (1d:04) | discover | ubuntu | [] | 192.168.0.22 | 08:f1:ea:7e:fc:a0 | None | ProLiant DL360 Gen10 | True |
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
2. Delete the discovered node.
[root@fuel ~]# fuel node --node-id 1 --delete-from-db --force
Nodes with ids [1] have been deleted from Fuel db.
3. Status on the fuel node listing.
• On the first listing, it is noticed that the node id and name get updated with information from the first discovery request after the above delete. Note, the “name” has the last 4 letters on the mac address from the discovered node.
• Note, the id is incremented after the delete on discovery of the first node.
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
| id | name | status | os_platform | roles | ip | mac | cluster | platform_name | online |
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
| 2 | Untitled (fc:a0) | discover | ubuntu | [] | 192.168.0.22 | 08:f1:ea:7e:fc:a0 | None | ProLiant DL360 Gen10 | True |
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
• On subsequent listings, it can be noticed from the discovery information is overwritten with the same “name” and “id”, we have 4 nodes here, all 4 discoveries cycle against the same “name” and “id”.
[root@fuel ~]# fuel2 node list
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
| id | name | status | os_platform | roles | ip | mac | cluster | platform_name | online |
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
| 2 | Untitled (fc:a0) | discover | ubuntu | [] | 192.168.0.20 | 08:f1:ea:7e:1d:04 | None | ProLiant DL360 Gen10 | True |
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+

root@fuel ~]# fuel2 node list
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
| id | name | status | os_platform | roles | ip | mac | cluster | platform_name | online |
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
| 2 | Untitled (fc:a0) | discover | ubuntu | [] | 192.168.0.21 | 08:f1:ea:7e:dc:98 | None | ProLiant DL360 Gen10 | True |
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+

root@fuel ~]# fuel2 node list
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
| id | name | status | os_platform | roles | ip | mac | cluster | platform_name | online |
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+
| 2 | Untitled (fc:a0) | discover | ubuntu | [] | 192.168.0.23 | 08:f1:ea:7e:ec:4d | None | ProLiant DL360 Gen10 | True |
+----+------------------+----------+-------------+-------+--------------+-------------------+---------+----------------------+--------+

4. There is no DHCP flapping. The mapping between the IP’s and MAC’s never change, or at least did not change on these runs.
5. Fuel version
[root@fuel ~]# fuel --fuel-version
api: '1'
auth_required: true
feature_groups:
- mirantis
- advanced
openstack_version: pike-12.0
release: '12.0'