Fuel for OpenStack

Key 'meta' is absent in bond properties

Bug #1652068 reported by Sergey Novikov on 2016-12-22

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Fuel for OpenStack	Fix Committed	High	Fedor Zhadaev	Fuel for OpenStack 11.0
Mitaka	Fix Released	High	Fedor Zhadaev	Fuel for OpenStack 9.2
Newton	Fix Committed	High	Fedor Zhadaev	Fuel for OpenStack 10.1

Bug Description

Detailed bug description:
The key 'meta' is absent in bond properties http://paste.openstack.org/show/593147/ .
and it is reason why we cannot check that dpdk or sriov is available for this bond. I did this suggestion due to analogy with iface properties http://paste.openstack.org/show/593150/ . May be, I'm wrong, and there is another way to define availability of dpdk and sriov for corresponding bond. Please, clarify me this moment.

Steps to reproduce:
1. Setup fuel master node
2. Bootstrap some node
3. Assign role "compute" to this node
4. Choose 2 ifaces for which dpdk is available
5. Bond them
6. Get bond properties using REST API call `GET /api/nodes/<node_id>/interfaces/`

Description of the environment:
snapshot #662

Tags:

Fedor Zhadaev (fzhadaev) on 2016-12-22

Changed in fuel:
assignee:	nobody → Fedor Zhadaev (fzhadaev)

Nastya Urlapova (aurlapova) on 2016-12-23

Changed in fuel:
status:	New → Confirmed
tags:	added: swarm-fail

Revision history for this message

Andriy Popovych (popovych-andrey) wrote on 2016-12-28:

dpdk, sriov, offloadin_modes for bond programmable attributes. Bond is logical structure which creates on client and then stores in nailgun. All that attributes can be calculated based on NICs meta (bond oflloading_modes are intersection of NIC offloading_modes, dpdk availability relay on NICs dpdk availability in meta etc.). So in any case we should calculate it in client at least first time.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-28: Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/415448

Fedor Zhadaev (fzhadaev) on 2016-12-28

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

Aleksey Kasatkin (alekseyk-ru) wrote on 2016-12-29:

Andriy, I support your view mostly but AFAIC backend should check offloading_modes as at least CLI user can provide any input actually (and tests use own client). Backend verifies configuration as much as possible, it is natural as it cannot trust clients in most cases (clients do not have whole picture, backend has most part of business logic).

Revision history for this message

Aleksey Kasatkin (alekseyk-ru) wrote on 2016-12-29:

It can be helpful that backend provides meta on GET calls (for the same reason - backend has the most complete picture in it; also, it's easier to maintain meta calculation in one place than in several places).

Fedor Zhadaev (fzhadaev) on 2017-01-09

Changed in fuel:
milestone:	9.2 → 11.0

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-09: Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/417909

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-09: Fix proposed to fuel-web (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/417914

Revision history for this message

Aleksey Kasatkin (alekseyk-ru) wrote on 2017-01-11:

Seems, this does not fix https://bugs.launchpad.net/fuel/+bug/1652076 so it should be treated separately.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-12: Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/417909
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=98fe7f6de18e272521d2bdc4c2a4207bd877efb8
Submitter: Jenkins
Branch: master

commit 98fe7f6de18e272521d2bdc4c2a4207bd877efb8
Author: Fedor Zhadaev <email address hidden>
Date: Mon Jan 9 19:00:39 2017 +0400

Add 'meta' to bond properties

Dynamically generate 'meta' for bond and put there information
about DPDK availability and structure of available offloading modes.

    Change-Id: Id030dda19b150b56db5624bd45c8f767d0748a47
    Closes-bug: #1652068
    (cherry picked from commit 13be8e85c1d5db7f45893b141d1c8e6ef6eeedab)

Changed in fuel:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-12: Fix merged to fuel-web (stable/newton)

Reviewed: https://review.openstack.org/417914
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=9568c1c155cf8f324228aaba9dda397519bbb39f
Submitter: Jenkins
Branch: stable/newton

commit 9568c1c155cf8f324228aaba9dda397519bbb39f
Author: Fedor Zhadaev <email address hidden>
Date: Mon Jan 9 19:00:39 2017 +0400

Add 'meta' to bond properties

Dynamically generate 'meta' for bond and put there information
about DPDK availability and structure of available offloading modes.

    Change-Id: Id030dda19b150b56db5624bd45c8f767d0748a47
    Closes-bug: #1652068
    (cherry picked from commit 13be8e85c1d5db7f45893b141d1c8e6ef6eeedab)