Fuel for OpenStack

[PluginManager] Plugins which can be removed does not do this

Bug #1632377 reported by Vladimir Sharshov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Vladimir Sharshov
Fuel for OpenStack 11.0
Mitaka
Fix Released
High
Vladimir Sharshov
Fuel for OpenStack 9.2
Newton
Fix Released
High
Vladimir Sharshov
Fuel for OpenStack 10.1

Bug Description

Detailed bug description:

    Plugin was not used by any clusters, but it could not be deleted by sync command.

    Cannot delete plugin fuel_plugin_example_v4_deleted from DB. The one of possible reasons: is still used at least in one cluster, but it is already deleted on filesystem. Please reinstall it using package or disable it in every cluster

Steps to reproduce:
     - build example plugin using fpb from https://github.com/openstack/fuel-plugins
     - install package `rpm -i fuel_plugin_example_v4/fuel_plugin_example_v4-4.0-4.0.0-1.noarch.rpm`
     - run `fuel2 plugins sync`
     - run `yum remove -y fuel_plugin_example_v4-4.0`
     - run `fuel2 plugins sync`
     - check `fuel2 plugins list`

Expected results:
     fuel_plugin_example_v4 should not be present in the list

Actual result:
    fuel_plugin_example_v4 still present in the list

Reproducibility:
    Always

Workaround:
    Use `fuel plugins --remove plugin-name==1.0.1`

Impact:
    Deployer can be misleading, because back side of this bug. Plugins which deleted by yum, but used in cluster, will be removed from DB instead of raising error.

Description of the environment:
    Fuel 9.1

Additional information:
    No

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/385066

Changed in fuel:
status: Confirmed → In Progress
Alexey Shtokolov (ashtokolov)
no longer affects: fuel/future
OpenStack Infra (hudson-openstack)
Changed in fuel:
assignee: Vladimir Sharshov (vsharshov) → Alexey Shtokolov (ashtokolov)
OpenStack Infra (hudson-openstack)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/418261

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/418261
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=f982baccb2dc288815d4d9195cfdde0477d361a4
Submitter: Jenkins
Branch: stable/mitaka

commit f982baccb2dc288815d4d9195cfdde0477d361a4
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Tue Oct 11 18:47:14 2016 +0300

    Fix wrong detection of plugin deletable property

    Add tests

    Change-Id: I1577f2035777319219980ec181d8275597c5bced
    Closes-Bug: #1632377

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/418447

Ekaterina Shutova (eshutova)
tags: added: on-verification
Dmitry Pyzhov (dpyzhov)
no longer affects: fuel/ocata
Revision history for this message
Ekaterina Shutova (eshutova) wrote :

Verified on 9.2 snapshot #746.

tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/385066
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=e1b05610a2ee931386808252f55ab45372c61939
Submitter: Jenkins
Branch: master

commit e1b05610a2ee931386808252f55ab45372c61939
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Tue Oct 11 18:47:14 2016 +0300

    Fix wrong detection of plugin deletable property

    Add tests

    Change-Id: I1577f2035777319219980ec181d8275597c5bced
    Closes-Bug: #1632377
    (cherry picked from commit f982baccb2dc288815d4d9195cfdde0477d361a4)

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/newton)

Reviewed: https://review.openstack.org/418447
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4f410f586c38280dd99ff898e467c37412d02e58
Submitter: Jenkins
Branch: stable/newton

commit 4f410f586c38280dd99ff898e467c37412d02e58
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Tue Oct 11 18:47:14 2016 +0300

    Fix wrong detection of plugin deletable property

    Add tests

    Change-Id: I1577f2035777319219980ec181d8275597c5bced
    Closes-Bug: #1632377
    (cherry picked from commit f982baccb2dc288815d4d9195cfdde0477d361a4)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 11.0.0.0rc1

This issue was fixed in the openstack/fuel-web 11.0.0.0rc1 release candidate.

Revision history for this message
Vladimir Khlyunev (vkhlyunev) wrote :

Verified on 1575 build

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.