Noop Run tasks are not set to fail_on_error = false

Bug #1626067 reported by Alexandra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
In Progress
High
Vladimir Kuklin
Mitaka
Won't Fix
High
Fuel Sustaining
Newton
Triaged
High
Fuel Sustaining
Ocata
In Progress
High
Vladimir Kuklin

Bug Description

Not all custom changes are mentioned in results of fuel noop run.

It happens in case of several changes in the same time. Below described scenario is just for example (scenario from automated test)

Steps:
1) Deploy env
2) Make these changes:
- remove heat service on primary controller:
# pcs resource delete p_heat-engine
- rename role SwiftOperator -> SwiftOperator-new
- modify /etc/nova/nova.conf on compute
3) Run fuel task with --noop on target nodes:
# fuel2 env nodes deploy -e 1 -n 1 2 -f --noop
# Deployment task with id 13 for the nodes 1, 2 within the environment 1 has been started.
4) Wait for 'ready' state and check summary
# fuel deployment-tasks --tid 13 --include-summary

Expected result:
Three messages are in summary:
1) Pcmk_resource[p_heat-engine]/ensure', u'message': "u'current_value absent, should be present (noop)'
2) Keystone_role[SwiftOperator]/ensure', u'message': u'current_value absent, should be present (noop)
3) Nova_config[oslo_messaging_rabbit/amqp_durable_queues]/value', u'message': u'current_value <value>, should be False (noop)

Actual result:
message #2 is not found
Task swift-keystone is in pending state

Please note that required message occurs in case of single custom change (swift-keystone is ready):
[root@nailgun ~]# fuel deployment-tasks --tid 13 --include-summary --task-name swift-keystone
task_name | node_id | status | time_start | time_end | summary
---------------+---------+--------+----------------------------+----------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
swift-keystone | 1 | ready | 2016-09-21T11:56:04.596236 | 2016-09-21T11:56:29.699072 | {u'status': u'stopped', u'idling': 0, u'lastrun': 1474458989, u'enabled': 1, u'err_msg': u'Process not running but not empty lockfile is present. Trying to remove lockfile...ok.', u'events': {u'failure': 0, u'total': 1, u'noop': 1, u'success': 0}, u'running': 0, u'version': {u'puppet': u'3.8.5', u'config': 1474458968}, u'stopped': 1, u'time': {u'keystone_service': 0.001201779, u'keystone_role': 0.000799062, u'keystone_user': 6.308973962, u'keystone_endpoint': 0.0005108739999999999, u'schedule': 0.000380549, u'haproxy_backend_status': 0.008551122000000001, u'last_run': 1474458989, u'config_retrieval': 1.172574691, u'filebucket': 0.000826531, u'total': 13.211445948, u'anchor': 0.0004985329999999999, u'keystone_user_role': 5.717128845}, u'output': u'Currently stopped; last completed run 0 seconds ago', u'runtime': 0, u'changes': {u'total': 0}, u'raw_report': [{u'source': u'/Stage[main]/Swift::Keystone::Auth/Keystone_role[SwiftOperator]/ensure', u'message': u'current_value absent, should be present (noop)'}, {u'source': u'Class[Swift::Keystone::Auth]', u'message': u"Would have triggered 'refresh' from 1 events"}, {u'source': u'Stage[main]', u'message': u"Would have triggered 'refresh' from 1 events"}, {u'source': u'Puppet', u'message': u'Finished catalog run in 19.11 seconds'}], u'resources': {u'scheduled': 0, u'changed_resources': u'', u'failed_resources': u'', u'restarted': 0, u'changed': 0, u'failed': 0, u'skipped': 0, u'failed_to_restart': 0, u'out_of_sync': 1, u'total': 27}}

Env: 9.1 snapshot #286
Link to diagnostic snapshot: https://drive.google.com/open?id=0BxmbtGZe1aPtOVFySTJRS0dLa0E
Please find task history logs attached

Revision history for this message
Alexandra (aallakhverdieva) wrote :
Changed in fuel:
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
tags: added: area-library
no longer affects: fuel/newton
tags: added: area-python
removed: area-library
tags: added: feature-noop-deployment
summary: - Not all custom changes are mentioned in results of fuel noop run
+ Noop Run tasks are not set to fail_on_error = false
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/411972

Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Vladimir Kuklin (vkuklin)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Vladimir Kuklin (<email address hidden>) on branch: master
Review: https://review.openstack.org/411972
Reason: It seems to be not the best idea to edit graph serialization on the fly for noop run. This fix should be moved to task executor

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-astute (master)

Fix proposed to branch: master
Review: https://review.openstack.org/412504

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-astute (master)

Change abandoned by Vladimir Kuklin (<email address hidden>) on branch: master
Review: https://review.openstack.org/412504

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.