Fuel for OpenStack

Invalid api response in case all graphs deleted

Bug #1609290 reported by Kate Pimenova on 2016-08-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Fuel for OpenStack	Fix Committed	Medium	Alexander Bochkarev	Fuel for OpenStack 10.0

Bug Description

This bug always reproducible on the fake ui

Steps to reproduce:
- create new environment
- go to Workflows tab - there is only one "default" cluster-level graph in the table
- delete this default cluster graph
- refresh the page

Expected results: there should be no cluster-level graphs in the table

Actual result: a few "default" release graphs appear in the table.
GET /api/clusters/1/deployment_graphs returns http://paste.openstack.org/show/547721/

See original description

Tags:

Revision history for this message

Kate Pimenova (kpimenova) wrote on 2016-08-03:

Screenshot from 2016-08-03 11-04-28.png Edit (162.8 KiB, image/png)

Julia Aranovich (jkirnosova) on 2016-08-03

Changed in fuel:
importance:	Undecided → High
milestone:	none → 10.0
description:	updated
tags:	added: area-python

Ilya Kutukov (ikutukov) on 2016-08-03

Changed in fuel:
assignee:	Fuel Sustaining (fuel-sustaining-team) → Fuel Toolbox (fuel-toolbox)

Ivan Ponomarev (ivanzipfer) on 2016-08-04

Changed in fuel:
status:	New → Confirmed
importance:	High → Medium

Alexander Bochkarev (abochkarev) on 2016-08-08

Changed in fuel:
assignee:	Fuel Toolbox (fuel-toolbox) → Alexander Bochkarev (abochkarev)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-08-08: Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/352387

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-08-17: Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/352387
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=9a974bc169afb66b76761c1f1b95004ca039724d
Submitter: Jenkins
Branch: master

commit 9a974bc169afb66b76761c1f1b95004ca039724d
Author: Alexander Bochkarev <email address hidden>
Date: Mon Aug 8 15:05:57 2016 +0300

Invalid api response in case all graphs deleted

    In the current implementation of the method 'to_list'
    all object instances are serialized regardless what
    the variable 'iterable' is: None or [].

    This patch allows to correctly handle such situations.
    In case if the variable 'iterable' is None all object
    instances are serialized, otherwise only selected from db.

Change-Id: I7b9913f364cfab085a8c94aec1435286a8e877f3
Closes-Bug: #1609290