Fuel for OpenStack

[LCM][Task idempotency] Task "workloads_collector_add" is not idempotent

Bug #1593723 reported by Sergey Novikov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Fuel Sustaining
Fuel for OpenStack 10.0
Mitaka
Fix Released
High
Stanislaw Bogatkin
Fuel for OpenStack 9.2

Bug Description

Steps to reproduce:
 1. deploy env with 1 controller + 1 compute + 1 cinder nodes
 2. Rerun task "workloads_collector_add" against primary controller node

 # Run task via fuel CLI client
 >fuel node --node-id <controller_id> --tasks workloads_collector_add
 #or the direct run of corresponding puppet manifest on primary controller node
 >puppet apply --noop /etc/puppet/modules/openstack_tasks/examples/keystone/workloads_collector_add.pp

Expected results: No resource changes
Actual result: The following resources were changed
- Keystone_tenant[services]
Reproducibility:
 100%
Description of the environment:
env was built from ISO MOS 9.0 #490
Additional information:
puppet's output: http://paste.openstack.org/show/516851/

See original description
Sergey Novikov (snovikov)
description: updated
Revision history for this message
Dmitry Klenov (dklenov) wrote :

Moving to 9.0-updates as there is no cluster outage.

tags: added: area-library
Maksim Malchuk (mmalchuk)
no longer affects: fuel/newton
Kyrylo Galanov (kgalanov)
Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Kyrylo Galanov (kgalanov)
Kyrylo Galanov (kgalanov)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Kyrylo Galanov (kgalanov) wrote :

https://review.openstack.org/#/c/332805

Revision history for this message
Kyrylo Galanov (kgalanov) wrote :

Upstream fix was committed to master.

Kyrylo Galanov (kgalanov)
Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-keystone 9.1.0

This issue was fixed in the openstack/puppet-keystone 9.1.0 release.

Dmitry Pyzhov (dpyzhov)
tags: added: 9.1-proposed
Revision history for this message
Kyrylo Galanov (kgalanov) wrote :

mitaka: https://review.openstack.org/#/c/353524/

Tatyana Kuterina (tkuterina)
tags: added: on-verification
Tatyana Kuterina (tkuterina)
tags: removed: on-verification
ElenaRossokhina (esolomina)
tags: added: on-verification
Revision history for this message
ElenaRossokhina (esolomina) wrote :

fix does not work - http://paste.openstack.org/show/570287/

tags: removed: on-verification
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
status: Fix Committed → Confirmed
assignee: Kyrylo Galanov (kgalanov) → Fuel Sustaining (fuel-sustaining-team)
Revision history for this message
Oleksiy Molchanov (omolchanov) wrote :

Actually the situation is that the patch is already is in puppet-keystone stable/mitaka branch, but in fuel we use mirror not from branch, but from latest tag 8.2.0, that doesn't contain this patch yet.

Changed in fuel:
status: Confirmed → Fix Committed
Revision history for this message
Stanislaw Bogatkin (sbogatkin) wrote :

It is already fixed for downstream stable/mitaka [0] by [1]

[0] https://github.com/fuel-infra/puppet-keystone/blob/stable/mitaka/lib/puppet/type/keystone_tenant.rb

[1] https://review.openstack.org/#/c/353524/

Ekaterina Shutova (eshutova)
tags: added: on-verification
Revision history for this message
Stanislaw Bogatkin (sbogatkin) wrote :

Reopened. We reference keystone module in mitaka by tag, not by branch. And current tag is 8.2.0 but bug was fixed only in 9.1.0. I preparing a fix for fuel-library.

Ekaterina Shutova (eshutova)
tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/409020

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/409020
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=d7331ca1f0e8cded306a81f2b47ff6fe271f12b4
Submitter: Jenkins
Branch: stable/mitaka

commit d7331ca1f0e8cded306a81f2b47ff6fe271f12b4
Author: Stanislaw Bogatkin <email address hidden>
Date: Fri Dec 9 11:34:12 2016 +0300

    Bump keystone version to have tenant value fixed

    Change-Id: I041c3589402d21429e9c593fadade747756fe8a4
    Closes-Bug: #1593723

TatyanaGladysheva (tgladysheva)
tags: added: on-verification
Revision history for this message
TatyanaGladysheva (tgladysheva) wrote :

Verified on 9.2 snapshot #636.

Actual results:
http://paste.openstack.org/show/592426/

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.