Fuel for OpenStack

horizon class contains template neutron attributes hardcoded

Bug #1591406 reported by oleksii shyman
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Alexey Deryugin
Fuel for OpenStack 10.0
Mitaka
Fix Released
Medium
Alexey Deryugin
Fuel for OpenStack 9.1
Newton
Fix Committed
Medium
Alexey Deryugin
Fuel for OpenStack 10.0

Bug Description

Detailed bug description:

Current implementation of horizon class in puppet-horizon holds well defined template for /etc/openstack_dashboard/local_settings.py that merges default neutron options with user defined options. Unfortunately only one user defined option "enable_distributed_router" gets its value from hiera, making tasks such as enabling lbaas complicated.

Expected results:
full list of neutron_options gets values from hiera

Additional information:

link to codes, where only one user-defined param used for class instantiation
https://github.com/openstack/fuel-library/blob/master/deployment/puppet/openstack_tasks/manifests/horizon/horizon.pp#L56

Tags: area-puppet
Bogdan Dobrelya (bogdando)
Changed in fuel:
milestone: none → 10.0
assignee: nobody → MOS Puppet Team (mos-puppet)
tags: added: area-puppet
Changed in fuel:
importance: Undecided → Medium
status: New → Confirmed
Ivan Berezovskiy (iberezovskiy)
Changed in fuel:
assignee: MOS Puppet Team (mos-puppet) → Alexey Deryugin (velovec)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/331058

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/331058
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=5b7e24a8eea0a6db479e85e530a554b08fa8bda2
Submitter: Jenkins
Branch: master

commit 5b7e24a8eea0a6db479e85e530a554b08fa8bda2
Author: Alexey Deryugin <email address hidden>
Date: Fri Jun 17 14:16:36 2016 +0300

    Make Horizon get Neutron related parameters from Hiera

    Current implementation of horizon class in puppet-horizon
    holds well defined template for /etc/openstack_dashboard/local_settings.py
    that merges default neutron options with user defined options.
    Unfortunately only one user defined option "enable_distributed_router"
    gets its value from hiera, so we need to add ability to configure all
    available parameters using hiera.

    Change-Id: Ie54eaea9dccc63bd0928ec84f9c23523b22521a2
    Closes-Bug: #1591406

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/344235

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/344235
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b13dc60f3f830dfde9999b7b158a107d5a27f50d
Submitter: Jenkins
Branch: stable/mitaka

commit b13dc60f3f830dfde9999b7b158a107d5a27f50d
Author: Alexey Deryugin <email address hidden>
Date: Fri Jun 17 14:16:36 2016 +0300

    Make Horizon get Neutron related parameters from Hiera

    Current implementation of horizon class in puppet-horizon
    holds well defined template for /etc/openstack_dashboard/local_settings.py
    that merges default neutron options with user defined options.
    Unfortunately only one user defined option "enable_distributed_router"
    gets its value from hiera, so we need to add ability to configure all
    available parameters using hiera.

    Change-Id: Ie54eaea9dccc63bd0928ec84f9c23523b22521a2
    Closes-Bug: #1591406
    (cherry picked from commit 5b7e24a8eea0a6db479e85e530a554b08fa8bda2)

Kristina Berezovskaia (kkuznetsova)
tags: added: on-verification
Revision history for this message
Kristina Berezovskaia (kkuznetsova) wrote :

Verify on
CUSTOM_VERSION=snapshot #142
MAGNET_LINK=magnet:?xt=urn:btih:bfec808dd71ff42c5613a3527733d9012bb1fabc&dn=MirantisOpenStack-9.0.iso&tr=http%3A%2F%2Ftracker01-bud.infra.mirantis.net%3A8080%2Fannounce&tr=http%3A%2F%2Ftracker01-scc.infra.mirantis.net%3A8080%2Fannounce&tr=http%3A%2F%2Ftracker01-msk.infra.mirantis.net%3A8080%2Fannounce&ws=http%3A%2F%2Fvault.infra.mirantis.net%2FMirantisOpenStack-9.0.iso
FUEL_QA_COMMIT=16d1700e2307bc06cacf969060bd454826a7d4db
UBUNTU_MIRROR_ID=ubuntu-2016-08-03-174238
CENTOS_MIRROR_ID=centos-7.2.1511-2016-05-31-083834
MOS_UBUNTU_MIRROR_ID=9.0-2016-08-15-132321
MOS_CENTOS_OS_MIRROR_ID=os-2016-06-23-135731
MOS_CENTOS_PROPOSED_MIRROR_ID=proposed-2016-08-15-172323
MOS_CENTOS_UPDATES_MIRROR_ID=updates-2016-06-23-135916
MOS_CENTOS_HOLDBACK_MIRROR_ID=holdback-2016-06-23-140047
MOS_CENTOS_HOTFIX_MIRROR_ID=hotfix-2016-07-18-162958
MOS_CENTOS_SECURITY_MIRROR_ID=security-2016-06-23-140002
(neutron+vxlan+dvr)
Check that in /etc/openstack_dashboard/local_settings.py
OPENSTACK_NEUTRON_NETWORK = {
    'enable_distributed_router': True,

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.