Fuel for OpenStack

unquoted variable usage and unnecessary bashisms

Bug #1588400 reported by Dmitry Burmistrov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Dmitry Burmistrov
Fuel for OpenStack 10.0
Mitaka
Fix Released
Low
Alexey Deryugin
Fuel for OpenStack 9.1

Bug Description

Detailed bug description:
 'files/fuel-ha-utils/ocf/ns_conntrackd' contains unquoted variables. Also there are unnecessary bashisms ("[[ ]]"), they can be replaced.
 Changes should be made for current master (Newton).
Steps to reproduce:
 -
Expected results:
 'files/fuel-ha-utils/ocf/ns_conntrackd' use quoted variables, use "[" instead of "[[" (if possible)
Actual result:
 'files/fuel-ha-utils/ocf/ns_conntrackd' contains unquoted 'rc' variable and '[[' in if expressions.
Reproducibility:
 -
Workaround:
 -
Impact:
 -
Description of the environment:
 Operation system: Ubuntu 14.04
 Versions of components: -
 Reference architecture: -
 Network model: -
 Related projects installed: -
Additional information:
 -

See original description
Tags: area-library
Dmitry Burmistrov (dmburmistrov)
Changed in fuel:
assignee: nobody → Dmitry Burmistrov (dmburmistrov)
OpenStack Infra (hudson-openstack)
Changed in fuel:
status: New → In Progress
Revision history for this message
Dina Belova (dbelova) wrote :

Dima, may you please provide additional information on what MOS is this targeted to and fill information regarding expected results/ actual results in the description as well?

Changed in fuel:
status: In Progress → Incomplete
Revision history for this message
Dmitry Burmistrov (dmburmistrov) wrote :

Dina, I updated description. Is it valid now? Thank you!

description: updated
Maksim Malchuk (mmalchuk)
Changed in fuel:
importance: Undecided → Low
milestone: none → 10.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/324348
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b3c51851dc5cc8f07085b3367ab70e373165edba
Submitter: Jenkins
Branch: master

commit b3c51851dc5cc8f07085b3367ab70e373165edba
Author: dmburmistrov <email address hidden>
Date: Thu Jun 2 13:13:38 2016 +0300

    Use safe conditions

    * don't use bashism
    * enquote variables

    Closes-Bug: #1588400

    Change-Id: I27869af311b2c193fa50908bf3dc3ce14c9ba031

Changed in fuel:
status: Incomplete → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/344237

Maksim Malchuk (mmalchuk)
no longer affects: fuel/newton
tags: added: area-library
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/344237
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=6d6c1408441199ae687b8edbecbee624a622c69b
Submitter: Jenkins
Branch: stable/mitaka

commit 6d6c1408441199ae687b8edbecbee624a622c69b
Author: dmburmistrov <email address hidden>
Date: Thu Jun 2 13:13:38 2016 +0300

    Use safe conditions

    * don't use bashism
    * enquote variables

    Closes-Bug: #1588400

    Change-Id: I27869af311b2c193fa50908bf3dc3ce14c9ba031
    (cherry picked from commit b3c51851dc5cc8f07085b3367ab70e373165edba)

Revision history for this message
Kristina Berezovskaia (kkuznetsova) wrote :

Verify
For verifying we only need to check code

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.