[fuel-octane] Octane fails due to mismatch in partition table for Ceph OSD node

Bug #1585938 reported by Pavel Chechetin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Oleg S. Gelbukh

Bug Description

Detailed bug description:
 A node deployed by Fuel 6.0 has different partition table than a node deployed by Fuel 8.0.
 Octane should update metadata for node before upgrade.
 The code for is present in Octane, but it isn't called for Ceph OSD node.

Steps to reproduce:
 octane upgrade-node $SEED_ENV_ID $CEPH_OSD_NODE_ID

Expected results:
 ceph-osd is upgraded

Actual result:
 ceph-osd fell in error state during provision step

Reproducibility:
 Always

Description of the environment:
 Source Fuel version: 6.0
 Destination Fuel version: 8.0
 Operation system: Ubuntu

Changed in fuel:
milestone: none → 8.0-updates
assignee: nobody → Fuel Octane (fuel-octane-team)
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/321474

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (master)

Fix proposed to branch: master
Review: https://review.openstack.org/321553

Changed in fuel:
assignee: Fuel Octane (fuel-octane-team) → Oleg S. Gelbukh (gelbuhos)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/321474
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=258d16b0f3dd9ebb8c4466108709911192507b69
Submitter: Jenkins
Branch: master

commit 258d16b0f3dd9ebb8c4466108709911192507b69
Author: Oleg Gelbukh <email address hidden>
Date: Thu May 26 11:05:04 2016 +0000

    Move disk.py module to util module

    Current location for disk.py modules is inconsistent with the
    usage of utils for basic operations on disks, not only their
    metadata. Non-metadata operations must be implemented by util
    module.

    Change-Id: Ia53b831f4b4d5c31da8801a8561b4721fd35d511
    Related-bug: 1585938
    Related-bug: 1575054

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/8.0)

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/322839

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/322839
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=75aa4161fe1e6edd64e4f46f2aed8a7ebf1bbced
Submitter: Jenkins
Branch: stable/8.0

commit 75aa4161fe1e6edd64e4f46f2aed8a7ebf1bbced
Author: Oleg Gelbukh <email address hidden>
Date: Thu May 26 11:05:04 2016 +0000

    Move disk.py module to util module

    Current location for disk.py modules is inconsistent with the
    usage of utils for basic operations on disks, not only their
    metadata. Non-metadata operations must be implemented by util
    module.

    Change-Id: Ia53b831f4b4d5c31da8801a8561b4721fd35d511
    Related-bug: 1585938
    Related-bug: 1575054
    (cherry picked from commit 258d16b0f3dd9ebb8c4466108709911192507b69)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/321553
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=46586a62df962b2ce00b5d8a63f6fd34c920a1f4
Submitter: Jenkins
Branch: master

commit 46586a62df962b2ce00b5d8a63f6fd34c920a1f4
Author: Oleg Gelbukh <email address hidden>
Date: Thu May 26 13:07:52 2016 +0000

    Improve partitions and disk metadata handling

    Partitions schema and disk metadata at nodes must be updated only
    if they are scheduled for reprovisioning, and the provisioning
    method has changed to incompatible (i.e. from 'cobbler' to 'image')
    due to the shift of release version.

    Move logic that manages partitions from upgrade handlers to function
    that actually initiates the re-provisioning of node. This ensures
    that for every node this is applied only once and only if necessary.

    Change-Id: I28718564543e3ccd92d985bd79c76e509e8eae1f
    Closes-bug: 1585938
    Closes-bug: 1575054

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/332832

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/332931

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/mitaka)
Download full text (40.5 KiB)

Reviewed: https://review.openstack.org/332931
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=24f3c396612eb0c69fbf06bab3cebbb9ca829426
Submitter: Jenkins
Branch: stable/mitaka

commit b34d749f1c281dafbdbf155bd86830dc8f2a9aa2
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 21:10:56 2016 +0300

    Support mock==1.8.0 in unit tests

    Use assert_called_once_with instead of assert_called_once that was
    introduced in 2.0.0.

    Change-Id: Ifb7699d4b552d148984961727355f0e23b487c7c

commit d60f1905143bb7576ffd670595de1c4aeafd7b34
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 02:01:52 2016 +0300

    Allow to authorize by the predefined admin_token

    The admin_token_auth middleware is added to keystone pipelines to
    allow authorization by admin_token.

    Change-Id: Ic03150305a669fad1446436a68051fb9aa25b892

commit cc7fab59f44ffef60285f8732d798f52469b2530
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:47:01 2016 +0300

    Reset default_domain_id before the keystone task

    The default_domain_id should be removed from keystone.conf after restore
    of DB and before to apply the keystone puppet task to avoid of using the
    configured domain as a default.

    Change-Id: I05a6c48532e8042496b3d8ccef53d65bf8c44653

commit e3f82399d567dbcfc1ae9a1ecbddba7bf5028fc8
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:32:47 2016 +0300

    Add helper function to iterate over parameters

    The helpers.iterate_parameters function allows to iterate over lines of
    INI-like files along with a context of information, such section,
    parameter and value.

    Change-Id: I55b179118116fd5dacf100754057ea6589782dc2

commit 5ed370a4fbb3369d0f75873d205ac7f0c655f93a
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:18:05 2016 +0300

    Add update_file context manager for local files

    The subprocess.update_file function provides an ability to update
    content of a local file by iterating over lines of an original file and
    forming a result content in a temporary file to replace the original
    file in the end. This function is very useful to change configuration
    files.

    Change-Id: I433a5da67887b231400dd63131799019f45c277c

commit 58f31e6c5f408630c42565ee53de6b59457bc84c
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jun 22 14:34:03 2016 +0000

    Escape passwords passed to openstack client

    If special symbols are used in password for 'admin' user in
    OpenStack, octane passes them to command line client as is
    and it breaks shell.

    Properly escape the password before passing it to subprocess.

    Change-Id: Iad635aec6d5b5cc32975937e00205b7e89dc99d9
    Closes-bug: 1585960

commit 896aba1191eeb59cf85cc8be6a2ae67e08b76070
Author: Yuriy Taraday <email address hidden>
Date: Wed Jun 22 15:28:45 2016 +0300

    Add absolute_import to util/docker.py to avoid local tempfile module

    Closes-Bug: 1595156
    Change-Id: I9484efce6fa7aec1b41cf592f9e9768d85931fa7

commit 46586a62df962b2ce00b5d8a63f6fd34c920a1f4
Author: Oleg Gelbukh <email address hidden>
Date: Thu M...

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/332832
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=a35313d561c2b66b9c7576ec0d9ff8e3425f94ed
Submitter: Jenkins
Branch: stable/8.0

commit a35313d561c2b66b9c7576ec0d9ff8e3425f94ed
Author: Oleg Gelbukh <email address hidden>
Date: Thu May 26 13:07:52 2016 +0000

    Improve partitions and disk metadata handling

    Partitions schema and disk metadata at nodes must be updated only
    if they are scheduled for reprovisioning, and the provisioning
    method has changed to incompatible (i.e. from 'cobbler' to 'image')
    due to the shift of release version.

    Move logic that manages partitions from upgrade handlers to function
    that actually initiates the re-provisioning of node. This ensures
    that for every node this is applied only once and only if necessary.

    Change-Id: I28718564543e3ccd92d985bd79c76e509e8eae1f
    Closes-bug: 1585938
    Closes-bug: 1575054
    (cherry picked from commit 46586a62df962b2ce00b5d8a63f6fd34c920a1f4)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.