MySQL OCF RA stop is not reliable

Bug #1585125 reported by Bogdan Dobrelya
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Bogdan Dobrelya
6.1.x
Triaged
High
MOS Maintenance
7.0.x
Fix Committed
High
MOS Maintenance
8.0.x
Fix Committed
High
Anton Chevychalov
Mitaka
Fix Released
High
Bogdan Dobrelya
Newton
Fix Released
High
Bogdan Dobrelya

Bug Description

If there is an SST in progress or stalled, the action stop will report successfully stopped as there is no pid found. But it shall check for SST as well. And if found, call the proc_stop. Only this way we can be sure the process has been stopped.

UX is high as it may leave a stale mysqld running and render the resource instance lost for a control plane, for example waiting for an SST to finish, which will never to happen.

Changed in fuel:
importance: Undecided → High
assignee: nobody → Bogdan Dobrelya (bogdando)
milestone: none → 10.0
tags: added: galera
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/287733

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/320491

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/320491
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=846e5fa7cc46e5f1c0a8dd17ab462535b0b95e5e
Submitter: Jenkins
Branch: master

commit 846e5fa7cc46e5f1c0a8dd17ab462535b0b95e5e
Author: Liubov Efremova <email address hidden>
Date: Thu Mar 3 14:29:32 2016 +0300

    MySQL OCF stop check for sst as well

    Fix action stop to consider MySQL not running if only there is no
    SST and no pid found.
    Fix proc_stop command to match mysqld by its datadir, fix its stop
    retry count and wait timeout

    Change-Id: If4e54f0cd656360268f55bdce7a2c1f5a506ece2
    Closes-bug: #1585125

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
tags: added: area-library
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/322067

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/mitaka)

Reviewed: https://review.openstack.org/322067
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=9b12cc2d75ec1abcf3d8e9eec7943307f8b732c4
Submitter: Jenkins
Branch: stable/mitaka

commit 9b12cc2d75ec1abcf3d8e9eec7943307f8b732c4
Author: Liubov Efremova <email address hidden>
Date: Thu Mar 3 14:29:32 2016 +0300

    MySQL OCF stop check for sst as well

    Fix action stop to consider MySQL not running if only there is no
    SST and no pid found.
    Fix proc_stop command to match mysqld by its datadir, fix its stop
    retry count and wait timeout

    Change-Id: If4e54f0cd656360268f55bdce7a2c1f5a506ece2
    Closes-bug: #1585125
    (cherry picked from commit 846e5fa7cc46e5f1c0a8dd17ab462535b0b95e5e)

tags: added: on-verification
Revision history for this message
Kyrylo Galanov (kgalanov) wrote :

Verified on ISO #465 RC1

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/7.0)

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/374219

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/7.0)

Reviewed: https://review.openstack.org/374219
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f9a2d479f3687157d2b17a927a09ce5f995522d6
Submitter: Jenkins
Branch: stable/7.0

commit f9a2d479f3687157d2b17a927a09ce5f995522d6
Author: Denis Puchkin <email address hidden>
Date: Wed Sep 21 17:38:54 2016 +0300

    Backport mysql OCF from stable/mitaka

    backport mysql ocf script from stable/mitaka

    Closes-bug: #1524826
    Closes-bug: #1542256
    Closes-bug: #1572239
    Closes-bug: #1572557
    Closes-bug: #1572601
    Closes-bug: #1574747
    Closes-bug: #1574497
    Closes-bug: #1576244
    Closes-bug: #1574999
    Closes-bug: #1578278
    Closes-bug: #1388779
    Closes-bug: #1574999
    Closes-bug: #1576244
    Closes-bug: #1583173
    Closes-bug: #1585125

    Change-Id: I1cc6f95884a8fbd5c3418ede89bdf9ec6864bdc8

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/377597

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/8.0)

Reviewed: https://review.openstack.org/377597
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=b3873f5f5a0bb1526b1269f163223ae48d6e21f5
Submitter: Jenkins
Branch: stable/8.0

commit b3873f5f5a0bb1526b1269f163223ae48d6e21f5
Author: Denis Puchkin <email address hidden>
Date: Tue Sep 27 13:20:25 2016 +0300

    Backport mysql OCF from stable/mitaka

    backport mysql ocf script from stable/mitaka

    Closes-bug: #1524826
    Closes-bug: #1542256
    Closes-bug: #1572239
    Closes-bug: #1572557
    Closes-bug: #1572601
    Closes-bug: #1574747
    Closes-bug: #1574497
    Closes-bug: #1576244
    Closes-bug: #1574999
    Closes-bug: #1578278
    Closes-bug: #1388779
    Closes-bug: #1574999
    Closes-bug: #1576244
    Closes-bug: #1583173
    Closes-bug: #1585125

    Change-Id: I1cc6f95884a8fbd5c3418ede89bdf9ec6864bdc8

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.