Fuel for OpenStack

rpc-related parameters for OS components need to be verified

Bug #1573592 reported by Sergey Kolekonov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Alexey Deryugin
Fuel for OpenStack 10.0
Mitaka
Won't Fix
High
Unassigned
Fuel for OpenStack 9.1

Bug Description

Detailed bug description:
Recently nearly all puppet-openstack modules were refactored to use common oslo::messaging::rabbit class to manage rpc-related parameters. Some hard-coded default values were changed to $::os_service_default, it means that currently they are equal to OpenStack defaults. It can lead to unwanted effects. Example commit:
https://github.com/openstack/puppet-nova/commit/94c3bbed7112aad97ae634844c275d74d5b3afed

Steps to reproduce:
Deploy recent MOS 10.0 ISO

Expected results:
All rpc-related parameters are set to the same values as it was before modules refactoring (as in MOS 9.0, for example)

Actual result:
rpc-related parameters are set to default values which are not always expected

Tags: 9.1-opposed
Ivan Berezovskiy (iberezovskiy)
Changed in fuel:
importance: Undecided → High
assignee: nobody → MOS Puppet Team (mos-puppet)
milestone: none → 10.0
status: New → Confirmed
Revision history for this message
Dmitry Burmistrov (dmburmistrov) wrote :

Puppet "heat" module doesn't have defaults changings.

Puppet "keystone" module has only one change in defaults - "rabbit_ha_queues", but this parameter is properly handled in "oslo" module (so behavior is not changed).

These modules shouldn't have such problems.

Revision history for this message
Nikita Karpin (mkarpin) wrote :

Tested this patch - https://review.openstack.org/#/c/305299/ and found that Puppet-ironic module also has "rabbit_ha_queues" parameter changed for case with 1 controller, but this change has no impact on the behaviour.

Revision history for this message
Dmitry Burmistrov (dmburmistrov) wrote :

In puppet-murano all changed defaults shouldn't cause problems - all these parameters are directly passed to murano module in fuel-library.

Revision history for this message
Dmitry Burmistrov (dmburmistrov) wrote :

puppet-mistral is not used in fuel-library or other known plugins.

Revision history for this message
Dmitry Burmistrov (dmburmistrov) wrote :

There are changes in puppet-aodh (related to kombu ssl settings), but fuel-library doesn't use ssl for rabbit - so aodh module shouldn't cause such errors.

Revision history for this message
Dmitry Burmistrov (dmburmistrov) wrote :

Sahara puppet module doesn't have changes in defaults.

Revision history for this message
Dmitry Burmistrov (dmburmistrov) wrote :

puppet-cinder also has no changes in defaults.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/310413

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/310523

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/310721

Revision history for this message
Sergey Kolekonov (skolekonov) wrote :

A patch for fuel-library to use updated puppet-neutron is here https://review.openstack.org/#/c/309933/

Sergey Kolekonov (skolekonov)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/310721
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=29134c29718681710eeeb5e6d9fbfab9000ba632
Submitter: Jenkins
Branch: master

commit 29134c29718681710eeeb5e6d9fbfab9000ba632
Author: dmburmistrov <email address hidden>
Date: Thu Apr 28 12:55:12 2016 +0300

    Explicitly set queue settings (nova)

    Upstream puppet modules switched to
    puppet-oslo usage, but they also changed
    defaults. This caused unwanted changes
    in behavior. Related bug is mentioned
    below. This patch "restores" previous
    values of message queue parameters.

    Change-Id: I5cf9f697911eeef5093306dbcf66647cebcbf91d
    Related-bug: #1573592

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/310523
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=3d6e79deace197e8dcd6260847b8bd8320aa3b27
Submitter: Jenkins
Branch: master

commit 3d6e79deace197e8dcd6260847b8bd8320aa3b27
Author: dmburmistrov <email address hidden>
Date: Wed Apr 27 18:45:01 2016 +0300

    Explicitly set queue settings (glance)

    Upstream puppet modules switched to
    puppet-oslo usage, but they also changed
    defaults. This caused unwanted changes
    in behavior. Related bug is mentioned
    below. This patch "restores" previous
    values of message queue parameters.

    Change-Id: Ie06912c16d8fb01c8d655794b9bc6adf912749f6
    Related-bug: #1573592

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/310413
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=c9e538057a2bdc8bf1c1fce4e68b183355d40dd2
Submitter: Jenkins
Branch: master

commit c9e538057a2bdc8bf1c1fce4e68b183355d40dd2
Author: dmburmistrov <email address hidden>
Date: Wed Apr 27 14:05:16 2016 +0300

    Explicitly set queue settings (ceilometer)

    Upstream puppet modules switched to
    puppet-oslo usage, but they also changed
    defaults. This caused unwanted changes
    in behavior. Related bug is mentioned
    below. This patch "restores" previous
    values of message queue parameters.

    Related-bug: #1573592

    Change-Id: Ica2d3779394c47e148aeb8927b53d72625e35229

Revision history for this message
Dmitry Burmistrov (dmburmistrov) wrote :

All related patches have been merged.

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Burmistrov (dmburmistrov)
Changed in fuel:
status: Fix Committed → In Progress
Revision history for this message
Dmitry Burmistrov (dmburmistrov) wrote :

my bad - not all modules are verified (returned "In Progress" state)

Ivan Berezovskiy (iberezovskiy)
Changed in fuel:
assignee: MOS Puppet Team (mos-puppet) → Alexey Deryugin (velovec)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/331239

OpenStack Infra (hudson-openstack)
Changed in fuel:
assignee: Alexey Deryugin (velovec) → Alex Schultz (alex-schultz)
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
assignee: Alex Schultz (alex-schultz) → Alexey Deryugin (velovec)
tags: added: 9.1-opposed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/331239
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=64b99da4df42fbc09bbaa99ab8913159c204dc6c
Submitter: Jenkins
Branch: master

commit 64b99da4df42fbc09bbaa99ab8913159c204dc6c
Author: Alexey Deryugin <email address hidden>
Date: Fri Jun 17 18:49:58 2016 +0300

    Make RabbitMQ Heartbeat related parameters configurable from hiera

    Now we use default values of haertbeat related parameters, and
    we need to have an ability to override them using Hiera.

    Change-Id: I6d5d26657883aff0f1ff8d3faa1176ff6a8eb220
    Closes-Bug: #1576320
    Closes-Bug: #1573592

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-library 10.0.0rc1

This issue was fixed in the openstack/fuel-library 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-library 10.0.0

This issue was fixed in the openstack/fuel-library 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.