Fuel for OpenStack

bootstrap_admin_node.sh continues even fuelmenu fails in the interactive mode

Bug #1569014 reported by Ilya Kharin on 2016-04-11

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Fuel for OpenStack	Fix Committed	High	Maksim Malchuk	Fuel for OpenStack 10.0
	Mitaka	Fix Released	High	Maksim Malchuk	Fuel for OpenStack 9.0

Bug Description

In case if you entered in fuelmenu during the installation of the master node and it fails by some reason with non-zero status the bootstrap process continues.

Steps to reproduce:
1. Boot from 9.0 ISO with the specified flag 'showmenu=yes'
2. Enter in fuelmenu
3. During the configuration fuelmenu fails and exit with non-zero exit status

Expected result:
The bootstrap process should be terminate.

Actual result:
The bootstrap process continues even in case you did not specify everything you wanted, and errors regarding fuelmenu failure are very hard to notice.

Workaround
Interrupt the bootstrap script, fix fuelmenu manually, and then run bootstrap_admin_node.sh again.

See original description

Tags:

Ilya Kharin (akscram) on 2016-04-11

description:

updated

Bartosz Kupidura (zynzel) on 2016-04-12

tags:	added: area-library
Changed in fuel:
assignee:	nobody → Fuel Library Team (fuel-library)
importance:	Undecided → High
status:	New → Confirmed
milestone:	none → 9.0

Maksim Malchuk (mmalchuk) on 2016-04-12

Changed in fuel:
assignee:	Fuel Library Team (fuel-library) → Maksim Malchuk (mmalchuk)

Revision history for this message

Matthew Mosesohn (raytrac3r) wrote on 2016-04-12:

Ilya, how did you get Fuelmenu to fail and exit? If there's a scenario that causes it to crash, we should fix that. There should be no scenario where fuelmenu exits nonzero. If there is and we really need to plan for it, we can add logic in bootstrap_admin_node.sh to catch it.

Revision history for this message

Maksim Malchuk (mmalchuk) wrote on 2016-04-12:

we should add a handler for Ctrl+C ?)

Matthew Mosesohn (raytrac3r) on 2016-04-12

Changed in fuel:
status:	Confirmed → Incomplete

Maksim Malchuk (mmalchuk) on 2016-04-12

Changed in fuel:
status:	Incomplete → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-12: Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/304589

Maksim Malchuk (mmalchuk) on 2016-04-12

Changed in fuel:
milestone:	9.0 → 10.0
tags:	added: team-bugfix

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-14: Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/304589
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=603cff3dfaa51b5eddff1fa94ad939185148f686
Submitter: Jenkins
Branch: master

commit 603cff3dfaa51b5eddff1fa94ad939185148f686
Author: Maksim Malchuk <email address hidden>
Date: Tue Apr 12 15:41:11 2016 +0300

Abort the Fuel installation if the fuelmenu fails

Deployment of Fuel Master should halt immediately if fuelmenu fails
to make it simpler to understand the reason of failure.

    Change-Id: I4a9b712c8fdf9cccb87a02500cdbf43793a63bf8
    Closes-Bug: #1569014
    Signed-off-by: Maksim Malchuk <email address hidden>

Changed in fuel:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-14: Fix proposed to fuel-main (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/305729

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-04-14: Fix merged to fuel-main (stable/mitaka)

Reviewed: https://review.openstack.org/305729
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=15ec782f8e6e2fc272bc931f059552528b6f70f9
Submitter: Jenkins
Branch: stable/mitaka

commit 15ec782f8e6e2fc272bc931f059552528b6f70f9
Author: Maksim Malchuk <email address hidden>
Date: Tue Apr 12 15:41:11 2016 +0300

Abort the Fuel installation if the fuelmenu fails

Deployment of Fuel Master should halt immediately if fuelmenu fails
to make it simpler to understand the reason of failure.

    Change-Id: I4a9b712c8fdf9cccb87a02500cdbf43793a63bf8
    Closes-Bug: #1569014
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 603cff3dfaa51b5eddff1fa94ad939185148f686)

Dmitry Belyaninov (dbelyaninov) on 2016-06-09

tags:

added: on-verification

Revision history for this message

Dmitry Belyaninov (dbelyaninov) wrote on 2016-06-10:

Verified on 9.0
[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
460
cat /etc/fuel_build_number:
460
cat /etc/fuel_release:
9.0
cat /etc/fuel_openstack_version:
mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
fuel-release-9.0.0-1.mos6349.noarch
python-packetary-9.0.0-1.mos140.noarch
fuel-bootstrap-cli-9.0.0-1.mos285.noarch
fuel-migrate-9.0.0-1.mos8450.noarch
rubygem-astute-9.0.0-1.mos750.noarch
fuel-mirror-9.0.0-1.mos140.noarch
shotgun-9.0.0-1.mos90.noarch
fuel-openstack-metadata-9.0.0-1.mos8741.noarch
fuel-notify-9.0.0-1.mos8450.noarch
nailgun-mcagents-9.0.0-1.mos750.noarch
fuel-provisioning-scripts-9.0.0-1.mos8741.noarch
python-fuelclient-9.0.0-1.mos325.noarch
fuel-9.0.0-1.mos6349.noarch
fuel-utils-9.0.0-1.mos8450.noarch
fuel-setup-9.0.0-1.mos6349.noarch
fuel-misc-9.0.0-1.mos8450.noarch
fuel-library9.0-9.0.0-1.mos8450.noarch
network-checker-9.0.0-1.mos74.x86_64
fuel-agent-9.0.0-1.mos285.noarch
fuel-ui-9.0.0-1.mos2717.noarch
fuel-ostf-9.0.0-1.mos935.noarch
fuelmenu-9.0.0-1.mos273.noarch
fuel-nailgun-9.0.0-1.mos8741.noarch
[root@nailgun ~]#

run bootstrap_admin_node.sh with changed config (delete showmenu or set it to yes)
break fuelmenu execution (Ctrl+c)
bootstrap_admin_node.sh stopped too.