Fuel for OpenStack

Incorrect inputs validation behaviour for Node Attribites

Bug #1567885 reported by Kate Pimenova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Kate Pimenova
Fuel for OpenStack 10.0
Mitaka
Fix Released
High
Kate Pimenova
Fuel for OpenStack 9.0
Newton
Fix Committed
High
Kate Pimenova
Fuel for OpenStack 10.0

Bug Description

Steps to reproduce:
1. Create environment with Hypervisor type KVM
2. Add a node to environment
3. Try to set invalid value in Node Attributes section for any attribute

Expected behavior:
 - impossible to set invalid value to the input (validation works)
 - impossible to click save button, in case of invalid configuration

Observed behavior:
 - it is possible to set invalid empty value to the input, validation not works
 - it is possible to click button save - then error message from server will be shown

Tags: area-ui
Revision history for this message
Kate Pimenova (kpimenova) wrote :
OpenStack Infra (hudson-openstack)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/301551
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=d4e0f58ae183075647ff6579d78a4dfb5e9e6922
Submitter: Jenkins
Branch: master

commit d4e0f58ae183075647ff6579d78a4dfb5e9e6922
Author: Kate Pimenova <email address hidden>
Date: Tue Apr 5 12:52:20 2016 +0300

    Validation for number inputs added

      - error message is shown in case of invalid input value
      - functional tests fixed according new changes
      - unit tests for number input validation added

    Closes-Bug: #1567885

    Change-Id: Ia1e24206eaa8e7cacb56aa7c7536553d7e599099

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/304536

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-ui (stable/mitaka)

Reviewed: https://review.openstack.org/304536
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=adb389244e8c28822aa822c7ee01cf330df91a8c
Submitter: Jenkins
Branch: stable/mitaka

commit adb389244e8c28822aa822c7ee01cf330df91a8c
Author: Kate Pimenova <email address hidden>
Date: Tue Apr 5 12:52:20 2016 +0300

    Validation for number inputs added

      - error message is shown in case of invalid input value
      - functional tests fixed according new changes
      - unit tests for number input validation added

    Closes-Bug: #1567885

    Change-Id: Ia1e24206eaa8e7cacb56aa7c7536553d7e599099
    (cherry picked from commit d4e0f58ae183075647ff6579d78a4dfb5e9e6922)

Grigory Mikhailov (gmikhailov)
tags: added: on-verification
Revision history for this message
Grigory Mikhailov (gmikhailov) wrote :

Verified on #fuel-9.0-mos-417 iso.
Values for all fields are worked correctly.

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id: 417
cat /etc/fuel_build_number: 417
cat /etc/fuel_release: 9.0
cat /etc/fuel_openstack_version: mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6347.noarch
 fuel-bootstrap-cli-9.0.0-1.mos284.noarch
 fuel-migrate-9.0.0-1.mos8398.noarch
 rubygem-astute-9.0.0-1.mos746.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8709.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-mirror-9.0.0-1.mos137.noarch
 fuel-openstack-metadata-9.0.0-1.mos8709.noarch
 fuel-notify-9.0.0-1.mos8398.noarch
 nailgun-mcagents-9.0.0-1.mos746.noarch
 python-fuelclient-9.0.0-1.mos316.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-9.0.0-1.mos6347.noarch
 fuel-utils-9.0.0-1.mos8398.noarch
 fuel-setup-9.0.0-1.mos6347.noarch
 fuel-library9.0-9.0.0-1.mos8398.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-agent-9.0.0-1.mos284.noarch
 fuel-ui-9.0.0-1.mos2706.noarch
 fuel-ostf-9.0.0-1.mos934.noarch
 fuel-misc-9.0.0-1.mos8398.noarch
 python-packetary-9.0.0-1.mos137.noarch
 fuel-nailgun-9.0.0-1.mos8709.noarch

tags: removed: on-verification
Revision history for this message
Kate Pimenova (kpimenova) wrote :

min and max values for this inputs should come from the server.
I've checked:
"dpdk": {"weight": 20, "label": "DPDK CPU pinning", "value": 0, "type": "number", "restrictions": [{"condition": "not ('experimental' in version:feature_groups)", "action": "hide"}], "min": 0, "description": "Number of CPUs for DPDK usage"}}}

 - there are no "max" attribute for this input

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.