Nailgun doesn't verify cluster settings that it has gotten
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Committed
|
Critical
|
Arthur Svechnikov | ||
Mitaka |
Fix Released
|
Critical
|
Arthur Svechnikov | ||
Newton |
Fix Released
|
Critical
|
Arthur Svechnikov |
Bug Description
Nailgun shouldn't fully rely on checkers implemented on UI side. It should check for concurrent settings for incompatibility itself.
Steps to reproduce:
1) Install master
2) Create cluster
3) Download settings from cli:
fuel settings --env 1 --download
4) Make a concurrent change inside downloaded settings, for ex.: set storage.
This option has restrictions: settings:
5) Upload an updated settings back to nailgun:
fuel settings --env 1 --upload --dir /root
Actual result:
settings has applied successfully without any warnings or errors.
Expected result:
there are an error message with a list of incompatibility settings.
Also one can check UI, there is a funny situation when you can't change settings because they are locked one by other. (see screenshot)
Fuel used:
[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
142
cat /etc/fuel_
142
cat /etc/fuel_release:
9.0
cat /etc/fuel_
mitaka-9.0
rpm -qa | egrep 'fuel|astute|
fuel-library9.
fuel-agent-
nailgun-
fuel-misc-
shotgun-
python-
fuel-bootstrap
fuel-provision
fuel-mirror-
fuel-openstack
fuel-notify-
fuel-ostf-
fuel-setup-
python-
network-
fuel-9.
fuel-utils-
fuel-nailgun-
fuel-release-
rubygem-
fuelmenu-
fuel-ui-
fuel-migrate-
Changed in fuel: | |
status: | New → Confirmed |
Changed in fuel: | |
assignee: | Fuel Python Team (fuel-python) → Arthur Svechnikov (asvechnikov) |
tags: | added: tricky |
@Alexander, this is a tech-debt feature, not a critical bug.
All settings validation should be performed by the API, not by the UI.