Fuel for OpenStack

Puppet service provider ignores 'status' and 'hasstatus'

Bug #1565870 reported by Bartosz Kupidura
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Critical
Bartosz Kupidura

Bug Description

Current puppet version installed on nodes (3.8.3-1~u14.04+mos1) ignores 'status' and 'hasstatus' in service resource.

root@node-1:~# cat a.pp
service {'ssh':
  hasstatus => false,
  status => '/bin/true',
  ensure => 'running',
}
root@node-1:~# puppet apply --debug a.pp
[...]
Info: Applying configuration version '1459786172'
Debug: Executing '/sbin/status ssh'
Debug: Finishing transaction 31027180
Debug: Storing state
Debug: Stored state in 2.22 seconds
Notice: Finished catalog run in 4.45 seconds
[...]

Instead of '/bin/true' '/sbin/status' was used to discover service status.

This will break some idempotency stuff, ex. https://github.com/openstack/fuel-library/blob/master/deployment/puppet/sysfs/manifests/service.pp

Looks similar to https://tickets.puppetlabs.com/browse/PUP-1293

Please update puppet package, and verify if 'status' is working.

Sergii Golovatiuk (sgolovatiuk)
Changed in fuel:
assignee: nobody → MOS Linux (mos-linux)
Revision history for this message
Maciej Relewicz (rlu) wrote :

on this version: 3.8.6-1puppetlabs1 (latest stable for trusty) this problem doesn't occurs:

Info: Applying configuration version '1459858109'
Debug: Executing '/bin/true'
Debug: Finishing transaction 26258440
Debug: Storing state
Debug: Stored state in 0.45 seconds
Notice: Finished catalog run in 0.84 seconds

Revision history for this message
Ivan Suzdal (isuzdal) wrote :

One question: is our manifests are compatible with newer puppet versions? AFAIK, last time when we tried to upgrade puppet - it broke our manifests.

Revision history for this message
Bartosz Kupidura (zynzel) wrote :

3.8.5 is maintenance release. It should not break anything.
https://docs.puppetlabs.com/puppet/3.8/reference/release_notes.html#puppet-385

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/puppet (master)

Fix proposed to branch: master
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/19246

Changed in fuel:
status: New → In Progress
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix proposed to packages/centos7/puppet (master)

Related fix proposed to branch: master
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/19260

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/puppet (master)

Reviewed: https://review.fuel-infra.org/19246
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 22069c50650fa77cb5657d0214854c27bad003a6
Author: Ivan Suzdal <email address hidden>
Date: Tue Apr 5 14:28:00 2016

Bump puppet version to 3.8.5

Change-Id: I25a723bab750e4de9388c84591c64577c825df33
Closes-Bug: #1565870

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to packages/centos7/puppet (master)

Reviewed: https://review.fuel-infra.org/19260
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 812dcc3b3cf8cda435ea29c091ccf8b159299e75
Author: Ivan Suzdal <email address hidden>
Date: Tue Apr 5 15:19:13 2016

Bump puppet version to 3.8.5

Rebuilt from [0]

[0] https://yum.puppetlabs.com/el/7/products/SRPMS/puppet-3.8.5-1.el7.src.rpm

Change-Id: I71b0afc7bdbfd12f5c6ee448b70d5e9f7bc1a480
Related-Bug: #1565870

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix proposed to packages/centos7/puppet (9.0)

Related fix proposed to branch: 9.0
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/19270

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/puppet (9.0)

Fix proposed to branch: 9.0
Change author: Ivan Suzdal <email address hidden>
Review: https://review.fuel-infra.org/19271

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to packages/centos7/puppet (9.0)

Reviewed: https://review.fuel-infra.org/19270
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0

Commit: eeb4deb64ef52a5113b631388a8d82694393faa0
Author: Ivan Suzdal <email address hidden>
Date: Tue Apr 5 17:40:18 2016

Bump puppet version to 3.8.5

Rebuilt from [0]

[0] https://yum.puppetlabs.com/el/7/products/SRPMS/puppet-3.8.5-1.el7.src.rpm

Change-Id: I71b0afc7bdbfd12f5c6ee448b70d5e9f7bc1a480
Related-Bug: #1565870
(cherry picked from commit 812dcc3b3cf8cda435ea29c091ccf8b159299e75)

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/puppet (9.0)

Reviewed: https://review.fuel-infra.org/19271
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0

Commit: 3cdd62b6771f4a4891a1201dca2c159262e44143
Author: Ivan Suzdal <email address hidden>
Date: Tue Apr 5 17:40:26 2016

Bump puppet version to 3.8.5

Change-Id: I25a723bab750e4de9388c84591c64577c825df33
Closes-Bug: #1565870
(cherry picked from commit 22069c50650fa77cb5657d0214854c27bad003a6)

Ivan Suzdal (isuzdal)
Changed in fuel:
assignee: MOS Linux (mos-linux) → Bartosz Kupidura (zynzel)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.