[upgrade] [regression] Ceph FSID and keys added to DB without migration

Bug #1563850 reported by Oleg S. Gelbukh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
slava valyavskiy
Mitaka
Fix Committed
High
slava valyavskiy

Bug Description

Detailed bug description:

The following commit introduces new fields into Nailgun DB without corresponding migration. This has potential to break upgrade process if old clusters don't have these fields (i.e. KeyError, compare to https://bugs.launchpad.net/fuel/+bug/1551339).

https://review.openstack.org/#/c/278413/10

Steps to reproduce:

1. Install the Fuel Master node version 8.0
2. Create an environment with Ceph storage
3. Dump the Nailgun database to file
4. Install the Fuel Master node version 9.0
5. Upload the database dump into Nailgun database
6. Run nailgun_syncdb
7. Run:

  echo "SELECT attributes_metadata FROM releases WHERE id=1;" | psql -At postgresql://nailgun@localhost/nailgun > file
  python -c "import json
  with open(\"tttttt\") as f:
    data = json.loads(f.read())
  print data['editable']['storage']['fsid']"

Expected results:

The JSON data field contents displayed.

Actual result:

KeyError: 'fsid'

Reproducibility:

Always

Workaround:

None

Impact:

Potential regression

Description of the environment:
 Operation system: Ubuntu
 Versions of components: 9
 Reference architecture: Ceph storage
 Network model: any
 Related projects installed: any

Additional information:
  N/A

Changed in fuel:
assignee: nobody → Fuel Python Team (fuel-python)
milestone: none → 9.0
tags: added: team-upgrades
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/303195

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/303195
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=014734cb34f51e5d8785bcef9f7e8a998e21316e
Submitter: Jenkins
Branch: master

commit 014734cb34f51e5d8785bcef9f7e8a998e21316e
Author: slava <email address hidden>
Date: Fri Apr 8 05:50:50 2016 +0300

    Add migration for new ceph fields

    Change-Id: Ie3295ac32a5a56ed882bd2d9a92c7092eaed5a8e
    Closes-Bug: #1563850

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/305371

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/306201

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (stable/mitaka)

Change abandoned by Valyavskiy Viacheslav (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/305371

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/306204

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/306201
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=07178944d6bb219a2b952655a77cfc0492f82218
Submitter: Jenkins
Branch: master

commit 07178944d6bb219a2b952655a77cfc0492f82218
Author: slava <email address hidden>
Date: Fri Apr 8 05:50:50 2016 +0300

    Add migration for new ceph fields

    Change-Id: I4cd7211d66491c7af837586d94cb18c22d3105dc
    Closes-Bug: #1563850

Changed in fuel:
milestone: 9.0 → 10.0
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/306204
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=780293388ac499792d96f63e582a2c5b4b6abb75
Submitter: Jenkins
Branch: stable/mitaka

commit 780293388ac499792d96f63e582a2c5b4b6abb75
Author: slava <email address hidden>
Date: Fri Apr 8 05:50:50 2016 +0300

    Add migration for new ceph fields

    Change-Id: I4cd7211d66491c7af837586d94cb18c22d3105dc
    Closes-Bug: #1563850

Changed in fuel:
status: In Progress → Fix Committed
tags: added: on-verification
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.