Deployment graph is not being stored into particular Nailgun task(transaction) table

Bug #1563317 reported by Vladimir Kuklin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Ilya Kutukov
Mitaka
Fix Released
High
Ilya Kutukov

Bug Description

fuel-nailgun-9.0.0-1.mos8590.noarch

Nailgun tasks table scheme does not contain a field for deployment graph. This seems to be a divergence from our spec for custom graph execution where we expect to store the merged pre-serialized graph into particular nailgun task/transaction.

nailgun=# \d tasks;

id | integer | NOT NULL DEFAULT nextval('tasks_id_seq'::regclass)
cluster_id | integer |
uuid | character varying(36) | NOT NULL
name | task_name | NOT NULL
message | text |
status | task_status | NOT NULL
progress | integer |
cache | text |
result | text |
parent_id | integer |
weight | double precision |
deleted_at | timestamp without time zone |
deployment_info | text |
cluster_settings | text |
network_settings | text |

Revision history for this message
Bug Checker Bot (bug-checker) wrote : Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info
Dmitry Pyzhov (dpyzhov)
tags: added: team-enhancements
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/303037

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

It seems it's not really a bug. It's missed functionality that we forgot to implement within a feature. Taking into account this, and that we passed HCF, I insist to close that bug as Won't Fixed for 9.0 and target it to 10.0.

tags: added: feature
Revision history for this message
Alexey Shtokolov (ashtokolov) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/317015

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/303037
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=a056929141fc8697e38cfff5f875c372131811e7
Submitter: Jenkins
Branch: master

commit a056929141fc8697e38cfff5f875c372131811e7
Author: Ilya Kutukov <email address hidden>
Date: Thu Apr 7 21:59:16 2016 +0300

    Deployment graph tasks parameters now saved in Transaction before deployment

    Deployment tasks snapshot is now saving during DeploymentTask message creation
    in Transaction.tasks_snapshot field.

    Methods:

        * attach_tasks_snapshot
        * get_tasks_snapshot

    are added to Transaction model.

    Handler /transactions/:transaction_id/deployment_history/
    now showing tasks parameters in output and supporting
    request parameter:
    /transactions/:transaction_id/deployment_history/?tasks_names=task1,task2

    Change-Id: I59446ef456f7d3bd249c686b7a8e1a93a364daf2
    Partial-Bug: #1563317
    DocImpact

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/321096

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/321572

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/321572
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=8e12c153a5cde4c5e560df8a5c6f8ea4a19d7735
Submitter: Jenkins
Branch: master

commit 8e12c153a5cde4c5e560df8a5c6f8ea4a19d7735
Author: Ilya Kutukov <email address hidden>
Date: Thu May 26 17:22:16 2016 +0300

    Move tasks snapshot field migration to 9.0.1

    Curently tasks snapshot field migration is included in 10.0.0
    migration. But in stable/mitaka branch it is in 9.0.1. This migration
    action should be located consistently in 9.0.1 in all branches.

    Change-Id: I235a6ac1ce551370a032b54f350ce2f3f339cb11
    Partial-Bug: #1563317

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/321096
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=11015024801fb7bcadd1919ada2196f593a765df
Submitter: Jenkins
Branch: stable/mitaka

commit 11015024801fb7bcadd1919ada2196f593a765df
Author: Ilya Kutukov <email address hidden>
Date: Thu Apr 7 21:59:16 2016 +0300

    Deployment graph tasks parameters now saved in Transaction before deployment

    Deployment tasks snapshot is now saving during DeploymentTask message creation
    in Transaction.tasks_snapshot field.

    Methods:

        * attach_tasks_snapshot
        * get_tasks_snapshot

    are added to Transaction model.

    Handler /transactions/:transaction_id/deployment_history/
    now showing tasks parameters in output and supporting
    request parameter:
    /transactions/:transaction_id/deployment_history/?tasks_names=task1,task2

    Change-Id: I59446ef456f7d3bd249c686b7a8e1a93a364daf2
    Partial-Bug: #1563317
    DocImpact

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/317015
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=058983896f953aec1bef481f5407da9d4f212293
Submitter: Jenkins
Branch: master

commit 058983896f953aec1bef481f5407da9d4f212293
Author: Ilya Kutukov <email address hidden>
Date: Mon May 16 20:28:35 2016 +0300

    Transaction tasks parameters support is added to CLI

    CLI parameter added

    fuel deployment-tasks --tid 1 --task-name mytask1,mytask2
    fuel2 task history show 1 --tasks-names mytask1 mytask2

    Deployment tasks history is now grouped by tasks.

    Closes-Bug: #1563317
    DocImpact

    Change-Id: I495b8884bea502b0eb9c10024e72745c688c3f58

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/322915

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (stable/mitaka)

Reviewed: https://review.openstack.org/322915
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=1a321f07c45dbc34da1ae6774c60bbc10530e9a0
Submitter: Jenkins
Branch: stable/mitaka

commit 1a321f07c45dbc34da1ae6774c60bbc10530e9a0
Author: Ilya Kutukov <email address hidden>
Date: Mon May 16 20:28:35 2016 +0300

    Transaction tasks parameters support is added to CLI

    CLI parameter added

    fuel deployment-tasks --tid 1 --task-name mytask1,mytask2
    fuel2 task history show 1 --tasks-names mytask1 mytask2

    Deployment tasks history is now grouped by tasks.

    Closes-Bug: #1563317
    DocImpact

    Change-Id: I495b8884bea502b0eb9c10024e72745c688c3f58
    (cherry picked from commit 058983896f953aec1bef481f5407da9d4f212293)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-fuelclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/323378

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/323378
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=40f7a87eca4e60fd877ad618b9de9204f260c730
Submitter: Jenkins
Branch: master

commit 40f7a87eca4e60fd877ad618b9de9204f260c730
Author: Ilya Kutukov <email address hidden>
Date: Tue May 31 16:35:13 2016 +0300

    Minor fixes to the formatter and task_names parameter getter

    Change-Id: I6e10180bdc2c427a7d1aaa04bdf444dbaf4404a0
    Related-Bug: #1563317

Maksym Strukov (unbelll)
tags: added: dev-to-verify
Revision history for this message
Ilya Kutukov (ikutukov) wrote :

To verify this bug, please,
1. deploy an environment from fuel command line

2. save returned deployment task id

3. run on master node
$ fuel deployment-tasks --tid [saved deployment task id] --show-parameters

4. run on master node
$ fuel2 task history show [saved deployment task id] --show-parameters

Output should be a big table with task name task parameters and list of nodes on which task was run

no longer affects: fuel/newton
tags: removed: dev-to-verify
tags: added: on-verification
Revision history for this message
Andrey Lavrentyev (alavrentyev) wrote :

Verified on 9.0-mos #467.

Got big tables with mentioned columns:
https://drive.google.com/open?id=0B5HPBFb7K7gXZmhidW4wTXFlcXc
https://drive.google.com/open?id=0B5HPBFb7K7gXYmYzeTZteWx5eGc

[root@nailgun ~]# shotgun2 short-report | head -n8
cat /etc/fuel_build_id:
 467
cat /etc/fuel_build_number:
 467
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.